Bug 1276244

Summary:	gluster-nfs : Server crashed due to an invalid reference
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.7.6	CC:	bugs, gluster-bugs, kkeithle, nbalacha, ndevos, rkavunga, skoduri
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1276243
Clones:	1276246 (view as bug list)		Environment:
Last Closed:	2015-11-17 06:01:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1276243
Bug Blocks:	1275914, 1276246

Description Jiffin 2015-10-29 08:44:19 UTC

+++ This bug was initially created as a clone of Bug #1276243 +++

Description of problem:

While testing gluster nfs with tiering, a crash is observed on different scenarios when fop such as access,read etc is performed. This issue is due to the invalid usage of null referenced variable 

Version-Release number of selected component (if applicable):
mainline

Actual results:
Crash is seen at different fops like read, access etc

Expected results:
Server should not crash even if fop failed.

--- Additional comment from Vijay Bellur on 2015-10-29 04:43:03 EDT ---

REVIEW: http://review.gluster.org/12458 (nfs : avoid invalid usage of `cs` variable in nfs fops) posted (#1) for review on master by jiffin tony Thottan (jthottan)

Comment 1 Vijay Bellur 2015-10-30 08:57:45 UTC

REVIEW: http://review.gluster.org/12471 (nfs : avoid invalid usage of `cs` variable in nfs fops) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)

Comment 2 Vijay Bellur 2015-10-30 16:20:34 UTC

COMMIT: http://review.gluster.org/12471 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit a4b44e872b7334e299853025e4faf9547ca18dfd
Author: Niels de Vos <ndevos>
Date:   Fri Oct 30 09:56:49 2015 +0100

    nfs : avoid invalid usage of `cs` variable in nfs fops
    
    Due to changes from http://review.gluster.org/#/c/12162/ a path variable
    is added to nfs3_log_common_res() and usually `cs->resolvedloc.path` is
    passed for that. But in certain fop function `cs` may not filled due error
    and when it is logged using nfs3_log_common_res() results in a crash.
    This patch will fix the same.
    
    Cherry picked from commit ee4f6175d1e1e6d6b82631d72c993db5691ad205:
    > Change-Id: I5a709818923e7884bd04e329834ee352a1b3a58f
    > BUG: 1276243
    > Signed-off-by: Jiffin Tony Thottan <jthottan>
    > Reviewed-on: http://review.gluster.org/12458
    > Reviewed-by: Niels de Vos <ndevos>
    > Tested-by: NetBSD Build System <jenkins.org>
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: N Balachandran <nbalacha>
    
    Change-Id: I5a709818923e7884bd04e329834ee352a1b3a58f
    BUG: 1276244
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/12471
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Raghavendra Talur 2015-11-17 06:01:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.6, please open a new bug report.

glusterfs-3.7.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-November/024359.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user