Bug 1276333

Summary: Anaconda crashes upon probing iSCSI LUN with existing LVM structures
Product: [Fedora] Fedora Reporter: Richard Bradfield <bradfier>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 23CC: anaconda-maint-list, awilliam, bradfier, dshea, g.kaviyarasu, jonathan, robatino, satellitgo, sgallagh, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: RejectedBlocker
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-30 12:48:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Anaconda log
none
Storage log
none
program.log
none
dnf.librepo.log
none
dnf.log
none
dnf.rpm.log
none
hawkey.log
none
ifcfg.log
none
packaging.log
none
X.log none

Description Richard Bradfield 2015-10-29 13:35:25 UTC
Created attachment 1087478 [details]
Anaconda log

Description of problem:
If an exported iSCSI LUN already contains LVM labels which match those autogenerated by the guided partitioning system, Anaconda will crash and the host will reboot when you attempt to probe the LUN (immediately after clicking "Login" at the iSCSI target selection window).

This could feasibly be encountered any time a user decides to perform a clean install, the installer should recognize the existing LVM volume group and either handle overwriting it, or alert the user to its existence.

Version-Release number of selected component (if applicable):
anaconda: /sbin/anaconda 23.19.10-1

How reproducible:
Always

Steps to Reproduce:
1. Install Fedora in a /boot on local | root on SAN iSCSI config with default guided partitioning.
2. Attempt to repeat the process without first wiping the exported LUN.


Actual results:
Anaconda crashes upon logging into the target and probing LUNs.

Expected results:
Anaconda should recognise and handle the old LVM volume group.

Comment 1 David Shea 2015-10-29 13:40:15 UTC
Please attach the other logs from /tmp at the time of this crash, in particular /tmp/anaconda-tb*

Comment 2 Richard Bradfield 2015-10-29 13:44:51 UTC
Created attachment 1087481 [details]
Storage log

Comment 3 Richard Bradfield 2015-10-29 13:45:17 UTC
Created attachment 1087482 [details]
program.log

Comment 4 Richard Bradfield 2015-10-29 13:46:22 UTC
There are no files matching that criteria in /tmp, only /tmp/anaconda.log

I will attach the other logs although I believe them unrelated.

Comment 5 Richard Bradfield 2015-10-29 13:46:58 UTC
Created attachment 1087512 [details]
dnf.librepo.log

Comment 6 Richard Bradfield 2015-10-29 13:47:28 UTC
Created attachment 1087526 [details]
dnf.log

Comment 7 Fedora Blocker Bugs Application 2015-10-29 13:48:46 UTC
Proposed as a Blocker for 23-final by Fedora user bradfirj using the blocker tracking app because:

 I believe this bug violates the "Network attached storage" blocker criteria:

The installer must be able to detect (if possible) and install to supported network-attached storage devices.

Supported types
Supported network-attached storage types include iSCSI, Fibre Channel and Fibre Channel over Ethernet (FCoE).

Comment 8 Richard Bradfield 2015-10-29 13:52:10 UTC
Created attachment 1087544 [details]
dnf.rpm.log

Comment 9 Richard Bradfield 2015-10-29 13:52:57 UTC
Created attachment 1087546 [details]
hawkey.log

Comment 10 Richard Bradfield 2015-10-29 13:53:16 UTC
Created attachment 1087547 [details]
ifcfg.log

Comment 11 Richard Bradfield 2015-10-29 13:54:21 UTC
Created attachment 1087548 [details]
packaging.log

Comment 12 Richard Bradfield 2015-10-29 13:55:20 UTC
Created attachment 1087549 [details]
X.log

Comment 13 David Shea 2015-10-29 13:56:31 UTC
As noted in your initial comment, and in the traceback, you have more than LVM volume group with the same name: one on a localally attached disk, and one on a disk being attached via iSCSI. LVM cannot handle this situation. Normally if anaconda detects mutliple VGs with the same name it will display a dialog advising the user to manually correct the storage, but this dialog is not currently displayed when a volume group is added from network storage.

Comment 14 Richard Bradfield 2015-10-29 14:09:40 UTC
It's worth noting this only presents if we try and install to an iSCSI volume when there is already an LVM volume group on both the network LUN and the local disk.

It's therefore probably enough of an edge case not to block on it, apologies for the false alarm.

Comment 15 Richard Bradfield 2015-10-29 14:10:37 UTC
(In reply to Richard Bradfield from comment #14)
> It's worth noting this only presents if we try and install to an iSCSI
> volume when there is already an LVM volume group on both the network LUN and
> the local disk.
> 
> It's therefore probably enough of an edge case not to block on it, apologies
> for the false alarm.

IE It requires at least two attempts (successful or not) at installing the OS before it can occur.

Comment 16 Stephen Gallagher 2015-10-29 14:12:13 UTC
OK, based on the discussion summarized here, I'm firmly -1 blocker on this issue.

Comment 17 David Shea 2015-10-29 14:36:58 UTC
FWIW this is fixed in rawhide by https://github.com/rhinstaller/anaconda/commit/5da4ee6b8825c52d7a75dba2012aff2efa595c8b

Comment 18 Adam Williamson 2015-10-29 23:32:06 UTC
Discussed at 2015-10-29 Go/No-Go meeting, acting as a blocker review meeting: https://meetbot-raw.fedoraproject.org/fedora-meeting-2/2015-10-29/f23-final-go_no_go-meeting_2.2015-10-29-16.00.html . Rejected as a blocker on the basis that this is a fairly unusual corner case, does not constitute a violation of the criterion - in most cases, iSCSI installs will work OK.

Comment 19 David Shea 2015-10-30 12:48:33 UTC
Closing this since it will not be going into F23 and is already in rawhide.