Bug 1277209

Summary: Double click on split table checkbox column shouldn't initiate item move
Product: [oVirt] ovirt-engine Reporter: Martin Betak <mbetak>
Component: Frontend.WebAdminAssignee: Vojtech Szocs <vszocs>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0.0CC: bugs, gklein, lsvaty, mbetak, ykaul
Target Milestone: ovirt-4.0.0-alphaFlags: rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
ecohen: devel_ack+
rule-engine: testing_ack+
Target Release: 4.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt 4.0.0 alpha1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:50:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Betak 2015-11-02 16:59:36 UTC 
Description of problem:

When using the SplitTable component with double click item moving enabled, the item is moved even when the double click occurs in a "checkbox" column with the purpose to (un)check the checkbox. Many times this "double" click is accidental and results in the item being moved to another table which requires manual correction.

The double click handler should probably be only registered on non-checkbox columns and not entire table row. 


Version-Release number of selected component (if applicable): 
4.0.0


Steps to Reproduce:
1. Look at any widget implemented using split table with double click moving and checkbox column: e.g Add Host Device dialog (vm tab -> host device sub tab -> add device)
2. Double click on checkbox "accidentally".

Actual results:
The item is moved to the second table.

Expected results:
Item should not be moved.
Comment 2 Einav Cohen 2015-11-05 15:11:42 UTC 
related to https://gerrit.ovirt.org/#/c/43726/ / bug 1099760, I assume.
Comment 3 Vojtech Szocs 2015-11-09 15:30:08 UTC 
(In reply to Einav Cohen from comment #2)
> related to https://gerrit.ovirt.org/#/c/43726/ / bug 1099760, I assume.

Correct.

The implementation uses GWT "cell preview" handler that applies to all table cells (columns).

The fix should be easy since CellPreviewEvent#getColumn exposes the index of the target column.
Comment 4 Lukas Svaty 2016-06-24 10:59:55 UTC 
verified in ovirt-engine-webadmin-portal-4.0.0.4-0.1.el7ev.noarch
Comment 5 Sandro Bonazzola 2016-07-05 07:50:43 UTC 
oVirt 4.0.0 has been released, closing current release.