Bug 1277209 - Double click on split table checkbox column shouldn't initiate item move
Summary: Double click on split table checkbox column shouldn't initiate item move
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Vojtech Szocs
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-02 16:59 UTC by Martin Betak
Modified: 2016-07-05 07:50 UTC (History)
5 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-05 07:50:43 UTC
oVirt Team: UX
rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
ecohen: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1099760 0 unspecified CLOSED [RFE] host device passthrough support 2021-02-22 00:41:40 UTC
oVirt gerrit 48454 0 'None' 'MERGED' 'webadmin,userportal: Fix SplitTable double-click on selection column' 2019-12-04 11:29:33 UTC

Internal Links: 1099760

Description Martin Betak 2015-11-02 16:59:36 UTC 
Description of problem:

When using the SplitTable component with double click item moving enabled, the item is moved even when the double click occurs in a "checkbox" column with the purpose to (un)check the checkbox. Many times this "double" click is accidental and results in the item being moved to another table which requires manual correction.

The double click handler should probably be only registered on non-checkbox columns and not entire table row. 


Version-Release number of selected component (if applicable): 
4.0.0


Steps to Reproduce:
1. Look at any widget implemented using split table with double click moving and checkbox column: e.g Add Host Device dialog (vm tab -> host device sub tab -> add device)
2. Double click on checkbox "accidentally".

Actual results:
The item is moved to the second table.

Expected results:
Item should not be moved.
Comment 2 Einav Cohen 2015-11-05 15:11:42 UTC 
related to https://gerrit.ovirt.org/#/c/43726/ / bug 1099760, I assume.
Comment 3 Vojtech Szocs 2015-11-09 15:30:08 UTC 
(In reply to Einav Cohen from comment #2)
> related to https://gerrit.ovirt.org/#/c/43726/ / bug 1099760, I assume.

Correct.

The implementation uses GWT "cell preview" handler that applies to all table cells (columns).

The fix should be easy since CellPreviewEvent#getColumn exposes the index of the target column.
Comment 4 Lukas Svaty 2016-06-24 10:59:55 UTC 
verified in ovirt-engine-webadmin-portal-4.0.0.4-0.1.el7ev.noarch
Comment 5 Sandro Bonazzola 2016-07-05 07:50:43 UTC 
oVirt 4.0.0 has been released, closing current release.
Note You need to log in before you can comment on or make changes to this bug.