Bug 1278279

Summary: EC: File healing promotes it to hot tier
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Bhaskarakiran <byarlaga>
Component: tierAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED ERRATA QA Contact: Bhaskarakiran <byarlaga>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: dlambrig, mzywusko, nchilaka, pkarampu, rcyriac, rhs-bugs, sankarshan, smohan, storage-qa-internal
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.1.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.5-7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1282761 (view as bug list) Environment:
Last Closed: 2016-03-01 05:51:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1260783, 1260923, 1282761, 1283757    

Description Bhaskarakiran 2015-11-05 07:23:02 UTC 
Description of problem:
=======================

After the file is healed, its getting promoted to hot tier. While creating 1GB file on 8+4 ec volume, brought down 4 of the bricks and bricks are up after the file is created. File got healed on the 4 bricks and saw the file in the hot tier, which should not be.


Version-Release number of selected component (if applicable):
=============================================================
3.7.5-5

[root@interstellar ~]# gluster --version
glusterfs 3.7.5 built on Oct 29 2015 10:11:53
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.
[root@interstellar ~]# 

How reproducible:
=================
100%

Steps to Reproduce:
===================
As in description

Actual results:
==============
File getting promoted to hot tier after heal


Expected results:
=================
Should remain in cold tier unless read/writes done to that file from client. Internal ops should not heat the file.

Additional info:
Comment 3 Joseph Elwin Fernandes 2015-11-13 08:46:00 UTC 
There are actually two issues here,

1) EC Selfheal traffic heats the file, as CTR Xlator is not distinguishing normal read-write FOP traffic from EC Sefheal FOP Traffic. Solution for this is detect the client-pid set in the FOP frame and ignore these FOPS in CTR Xlator. Need info from the EC dev Team, on the which client-pid EC Selfheal daemon uses to mark the FOPS different from regular FOPS.  

2) During a normal write the file gets heated up for read also, which is not correct and has performance cost w.r.t the extra updates to the database.  Well the reason for this is that each write that comes from the user to EC xlator converts to a read-modify-update FOPS. This read FOP doesnt have any marker on it to differentiate it from the regular read, and thus CTR tends to heat up the file.
Would require a marker on this read FOP or any such internal FOPs from EC xlator.
Comment 4 Bhaskarakiran 2015-11-26 09:17:05 UTC 
pls post the patch details.
Comment 6 Bhaskarakiran 2015-11-30 06:59:04 UTC 
verified this on 3.7.5-7 and works as expected.
Comment 8 errata-xmlrpc 2016-03-01 05:51:42 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0193.html