Bug 1278673

Summary:	Review Request: octave-jsonlab - JSON/UBJSON encoder and a decoder in the native matlab/octave language
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-13 04:23:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1276941

Description Igor Gnatenko 2015-11-06 06:40:46 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/octave-jsonlab.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/octave-jsonlab-1.1.0-1.fc24.src.rpm
Description:
JSONlab is a free and open-source implementation of a JSON/UBJSON encoder and
a decoder in the native MATLAB language. It can be used to convert a MATLAB
data structure (array, struct, cell, struct array and cell array) into
JSON/UBJSON formatted string, or decode a JSON/UBJSON file into MATLAB data.
JSONlab supports both MATLAB and GNU Octave (a free MATLAB clone).
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-12-01 22:49:06 UTC

You copy license to "COPYING" but nothing ever happens with that file?

- license is OK (BSD *or* GPLv3 is bizarre, but OK)
- license file is present, %license is used
- latest version
- provides/requires look sane:

Requires
--------
octave-jsonlab (rpmlib, GLIBC filtered):
    /bin/sh
    octave

Provides
--------
octave-jsonlab:
    octave-jsonlab

- scriptlets look sane
- builds and installs fine
- summary and description are OK
- package name is OK

Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/jsonlab_selftest.m.svn-base
octave-jsonlab.noarch: W: hidden-file-or-dir /usr/share/doc/octave-jsonlab/examples/.svn
octave-jsonlab.noarch: W: hidden-file-or-dir /usr/share/doc/octave-jsonlab/examples/.svn
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/tmp/props
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/example2.json.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/demo_jsonlab_basic.m.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/jsonlab_basictest.matlab.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/example3.json.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/demo_ubjson_basic.m.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/tmp/prop-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/tmp/text-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/jsonlab_selftest.matlab.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/jsonlab_speedtest.m.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/props
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/example1.json.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/tmp
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/text-base/example4.json.svn-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/prop-base
octave-jsonlab.noarch: E: version-control-internal-file /usr/share/doc/octave-jsonlab/examples/.svn/entries
Just nuke it!

octave-jsonlab.noarch: W: dangerous-command-in-%preun mv
1 packages and 0 specfiles checked; 18 errors, 3 warnings.

OK, comes from standard scriptlet.

Package is APPROVED. Please fix up the svn stuff when importing.

Comment 2 Gwyn Ciesla 2015-12-02 14:28:31 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/octave-jsonlab

Comment 3 Fedora Update System 2015-12-02 21:21:23 UTC

octave-jsonlab-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1bef950166

Comment 4 Igor Gnatenko 2015-12-02 21:24:44 UTC

> You copy license to "COPYING" but nothing ever happens with that file?
it is used somehow in octave pkg builder (otherwise it wont compile)

> Just nuke it!
done.

Comment 5 Fedora Update System 2015-12-04 01:35:30 UTC

octave-jsonlab-1.1.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update octave-jsonlab'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1bef950166

Comment 6 Fedora Update System 2015-12-13 04:22:59 UTC

octave-jsonlab-1.1.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.