Bug 1279056 (libminc)
| Summary: | Review Request: libminc - Core library and API of the MINC toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-12-13 04:23:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941, 1279064 | ||
|
Description
Igor Gnatenko
2015-11-07 14:51:03 UTC
%{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in /usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora.
I don't think libminc-devel should require cmake. It should be possible to link to the library using other build systems, and cmake is a fairly large dep.
Rpmlint
-------
Checking: libminc-2.3.00-1.fc24.i686.rpm
libminc-devel-2.3.00-1.fc24.i686.rpm
libminc-debuginfo-2.3.00-1.fc24.i686.rpm
libminc-2.3.00-1.fc24.src.rpm
libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0 exit
libminc-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
- latest version is packaged
- BSD license is OK
- license file is present, %license is used
- tests are present and pass
- ldconfig is called
- Provides/Requires look sane, apart from the cmake dep.
Looks fine apart from the minor issues listed above.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > %{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in > /usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora. arch-dependent packages should go to libdir/cmake/* > > I don't think libminc-devel should require cmake. It should be possible to > link to the library using other build systems, and cmake is a fairly large > dep. will remore > > Rpmlint > ------- > Checking: libminc-2.3.00-1.fc24.i686.rpm > libminc-devel-2.3.00-1.fc24.i686.rpm > libminc-debuginfo-2.3.00-1.fc24.i686.rpm > libminc-2.3.00-1.fc24.src.rpm > libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0 > exit looks like you got it 2 times, probably bug in rpmlint? What does it mean? > libminc-debuginfo.i686: W: spurious-executable-perm > /usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c will do chmod -x on that file. > 4 packages and 0 specfiles checked; 0 errors, 2 warnings. > > - latest version is packaged > - BSD license is OK > - license file is present, %license is used > - tests are present and pass > - ldconfig is called > - Provides/Requires look sane, apart from the cmake dep. > > Looks fine apart from the minor issues listed above. Ah, OK, I think I messed up the repoquery call. So ignore the part about /usr/lib/cmake.
>> libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
>> exit
> looks like you got it 2 times, probably bug in rpmlint? What does it mean?
Calling exit from shared libs is discouraged because it would kill the applications, the library should return an error instead. But it is not a packaging issue, just a (possible) bug or misdesign in the library. You can safely ignore it.
OK, so apart from the small fixes, everything is OK. Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/libminc libminc-2.3.00-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f libminc-2.3.00-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libminc' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f libminc-2.3.00-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f libminc-2.3.00-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libminc' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f libminc-2.3.00-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |