Bug 1279064 (minc-tools)
| Summary: | Review Request: minc-tools - Collection of tools that work on MINC format images | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Igor Gnatenko <ignatenko> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | igor.raits, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-08-22 07:30:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1279056 | ||
| Bug Blocks: | 1276941 | ||
|
Description
Igor Gnatenko
2015-11-07 15:51:13 UTC
mincview uses display from ImageMagick. Requires is missing. minchistory and mincpik are PERL scripts. The header should be modified to #!/usr/bin/perl. Then an automatic dependency on /usr/bin/perl will be generated, it is currently missing. rpmlint: minc-tools.i686: W: name-repeated-in-summary C minc-tools Yeah, Summary is currently pretty much useless. What do those tools do? Current %description can be almost used as Summary, and %description should be extended to give some information about the capabilities of those tools. minc-tools.i686: W: no-manual-page-for-binary minchistory minc-tools.i686: W: no-manual-page-for-binary mincmorph minc-tools.i686: W: no-manual-page-for-binary worldtovoxel minc-tools.i686: W: no-manual-page-for-binary mincpik minc-tools.src: W: name-repeated-in-summary C minc-tools 3 packages and 0 specfiles checked; 0 errors, 6 warnings. SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools.spec SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/minc-tools-2.3.00-2.fc24.src.rpm Build fails: + popd ~/build/BUILD/minc-tools-minc-tools-2-3-00 + sed -i -e '1s/^#!.*$/#!/usr/bin/perl' /builddir/build/BUILDROOT/minc-tools-2.3.00-2.fc24.x86_64/usr/bin/minchistory /builddir/build/BUILDROOT/minc-tools-2.3.00-2.fc24.x86_64/usr/bin/mincpik sed: -e expression #1, char 14: unknown option to `s' error: Bad exit status from /var/tmp/rpm-tmp.peNzO2 (%install) I think sed was confuse by too many dashes ;) ? Unfortunately I don't have time to work on these review requests anymore, sorry. |