Bug 1280431

Summary: [Director]External ceph configuration change from parameters to parameter_defaults
Product: Red Hat OpenStack Reporter: Ben Nemec <bnemec>
Component: documentationAssignee: Dan Macpherson <dmacpher>
Status: CLOSED CURRENTRELEASE QA Contact: Radek Bíba <rbiba>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.0 (Liberty)CC: adahms, bnemec, dmacpher, gfidente, johfulto, mburns, sankarshan, srevivo
Target Milestone: gaKeywords: Documentation
Target Release: 8.0 (Liberty)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-16 07:06:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed asciidoc changes none

Description Ben Nemec 2015-11-11 17:43:08 UTC
Description of problem: After we merged the downstream version of external ceph, the upstream review determined that the parameters involved should not be top-level, and should instead be set with parameter_defaults.  Because we have customers using parameters today, we'll need a note on upgrades to 8.0 that explains the need to move those settings from the parameters section to the parameter_defaults section.

So an existing user might have a configuration that looks like:

parameters:
  CephClientUserName: openstack

This needs to be changed to:

parameter_defaults:
  CephClientUserName: openstack

This applies to any of the parameters in the environments/puppet-ceph-external.yaml file in tripleo-heat-templates.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Mike Burns 2015-11-20 12:51:52 UTC
Just fyi, we need this change in for 8.0 GA.

Comment 4 Giulio Fidente 2016-02-17 11:42:59 UTC
Currently the kbase article [1] does not mention explicitly use of parameters: or parameter_defaults: and suggests to edit the sample environment file which seems best approach to me. Maybe we can close this BZ?

1. https://access.redhat.com/articles/1994713

Comment 5 Dan Macpherson 2016-02-17 14:43:53 UTC
Also, I should mention I'll be consolidating a lot of the Ceph/OpenStack information into a new guide for OSP 8.0. The article in comment #4 should only apply to 7.x for the moment, and when I write a draft of the new guide we can clarify the structure of the external Ceph environment file.

Comment 6 Ben Nemec 2016-03-07 15:13:41 UTC
We will also need a note in the upgrade section for anyone using external ceph from before the change was made.  Otherwise it sounds like we're covered for this.

Comment 7 Deepak C Shetty 2016-03-08 04:36:00 UTC
(In reply to Dan Macpherson from comment #5)
> Also, I should mention I'll be consolidating a lot of the Ceph/OpenStack
> information into a new guide for OSP 8.0. The article in comment #4 should
> only apply to 7.x for the moment, and when I write a draft of the new guide
> we can clarify the structure of the external Ceph environment file.

Just wanted to point out that for OSP 8.0 we are also planning to support hyper-converged compute+ceph setup. John Fulton from System Engg is working on the steps and doc for the same. Given you are consolidating ceph/openstack info ina new guide, I was hoping it would be good to document both (external ceph & converged ceph) setup in one guide, since both uses puppet-ceph-external.yaml. My 2 cents.

thanx,
deepak

Comment 10 John Fulton 2016-03-08 14:15:08 UTC
(In reply to Deepak C Shetty from comment #7)
> (In reply to Dan Macpherson from comment #5)
> > Also, I should mention I'll be consolidating a lot of the Ceph/OpenStack
> > information into a new guide for OSP 8.0. The article in comment #4 should
> > only apply to 7.x for the moment, and when I write a draft of the new guide
> > we can clarify the structure of the external Ceph environment file.
> 
> Just wanted to point out that for OSP 8.0 we are also planning to support
> hyper-converged compute+ceph setup. 

Not exactly. The plan is for a hyper-converged compute+ceph setup to be available in OSP8 but by support exception only. 

> John Fulton from System Engg is working on the steps and doc for the same. 

I am working on this and will have a separate Reference Implementation. This bug is relevant for that work, so thanks for CC'ing me to it. 

> Given you are consolidating
> ceph/openstack info ina new guide, I was hoping it would be good to document
> both (external ceph & converged ceph) setup in one guide, since both uses
> puppet-ceph-external.yaml. My 2 cents.

I respectfully disagree. IMO our documentation for what is supported should not include a hyper-converged compute+ceph setup until it is fully supported. Also, please keep in mind the difference between Documentation and Reference Architectures.

Comment 11 Deepak C Shetty 2016-03-08 14:25:12 UTC
> 
> > Given you are consolidating
> > ceph/openstack info ina new guide, I was hoping it would be good to document
> > both (external ceph & converged ceph) setup in one guide, since both uses
> > puppet-ceph-external.yaml. My 2 cents.
> 
> I respectfully disagree. IMO our documentation for what is supported should
> not include a hyper-converged compute+ceph setup until it is fully
> supported. Also, please keep in mind the difference between Documentation
> and Reference Architectures.

Thanks, clear now :)
Sorry for the noise.

Comment 15 Dan Macpherson 2016-03-16 04:24:15 UTC
Sent the Ceph Storage guide out for technical review. Switching Ceph bugs to POST.

Comment 16 Mike McCune 2016-03-28 22:29:36 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 17 Dan Macpherson 2016-04-29 06:42:33 UTC
Hi Ben,

The Ceph Storage Guide is out now. I've scanned through and it doesn't seem like we're using "parameters" for environment files.

https://access.redhat.com/documentation/en/red-hat-openstack-platform/version-8/red-hat-ceph-storage-for-the-overcloud/

Let me know if there's anything I should change in terms of the example environment files.

Comment 18 Dan Macpherson 2016-05-13 00:34:57 UTC
Hi Ben, Just following up... Any further changes required?

Comment 19 Ben Nemec 2016-05-13 19:27:49 UTC
We're fine on new installations because the sample file was changed.  The concern is anyone with external ceph upgrading from 7.x to 8 because their 7.x external-ceph environment file won't work in 8.  I think we probably want a note like the satellite one on https://access.redhat.com/documentation/en/red-hat-openstack-platform/8/director-installation-and-usage/chapter-10-upgrading-the-environment about changing puppet-ceph-external.yaml to use parameter_defaults.

Comment 20 Andrew Dahms 2016-05-16 07:13:35 UTC
Assigning Radek as the QA contact.

Radek - could you take a look at the changes for this bug?

Comment 21 Radek Bíba 2016-05-16 13:28:39 UTC
Created attachment 1157916 [details]
Proposed asciidoc changes

Looks wonderful. Attaching a few formatting and language improvements to consider. (At least the first formatting improvement is important because the affected text is now rendered as a single paragraph on the Portal.)

Comment 22 Dan Macpherson 2016-08-16 07:06:49 UTC
The feedback from Radek has been implemented and pushed live. Switching this to CLOSED.