Bug 1280464 (python-citeproc-py)

Summary:	Review Request: python-citeproc-py - Yet another Python CSL Processor
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-06 19:19:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1276941, 1280480

Description Igor Gnatenko 2015-11-11 19:37:19 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-citeproc-py.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-citeproc-py-0.3.0-1.fc24.src.rpm
Description: Yet another Python CSL Processor.
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-11-25 21:30:15 UTC

The same as for other packages: csl_unsorted seems to be a data processing script which should not be python-version specific.

Comment 2 Igor Gnatenko 2015-11-25 21:35:00 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-citeproc-py.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-citeproc-py-0.3.0-2.fc24.src.rpm

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-11-26 01:49:46 UTC

- license is OK
- license file is present, %license is used
- latest version
- follows new python guidelines
- rpmlint:
python2-citeproc-py.noarch: W: doc-file-dependency /usr/share/doc/python2-citeproc-py/examples/citeproc_json.py /usr/bin/env
python2-citeproc-py.noarch: W: doc-file-dependency /usr/share/doc/python2-citeproc-py/examples/bibtex.py /usr/bin/env

Should probably use #!/usr/bin/python2 (and /usr/bin/python3 in python3 subpackage).

- requires/provides are sane, except that /usr/bin/env is required (because it is used in docs)

Package is APPROVED.

Comment 4 Till Maas 2015-11-26 21:35:37 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-citeproc-py

Comment 5 Fedora Update System 2015-11-28 13:40:35 UTC

python-citeproc-py-0.3.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-92e495c2e6

Comment 6 Fedora Update System 2015-11-29 02:22:38 UTC

python-citeproc-py-0.3.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-citeproc-py'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-92e495c2e6

Comment 7 Fedora Update System 2015-12-06 19:19:26 UTC

python-citeproc-py-0.3.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.