Bug 1281578

Summary:	virt-inspector returns version 6.3 for win10 images (should return 10.0)
Product:	[Community] Virtualization Tools	Reporter:	Richard Tollerton <rich.tollerton>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	ptoscano, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-13 19:00:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard Tollerton 2015-11-12 20:44:12 UTC

Allegedly HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\CurrentVersion is now locked at 6.3 (i.e. win8.1) and there are new, undocumented values HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\CurrentMajorVersionNumber and HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\CurrentMinorVersionNumber that need to be checked. cf http://stackoverflow.com/questions/31072543/reliable-way-to-get-windows-version-from-registry.

Workaround is to use ProductName instead.

Comment 1 Richard W.M. Jones 2015-11-12 22:45:33 UTC

Oh that is nuts.  Thanks for altering me to this change.

Comment 2 Richard Tollerton 2015-11-12 23:14:34 UTC

Related question: I only care about this because virt-install isn't autodetecting --os-variant on an existing disk image (or at least it's not documented as doing so). Should I file a bug report with them on this? Or are virt-manager dependencies on libguestfs a problem?

Comment 3 Richard W.M. Jones 2015-11-13 08:51:50 UTC

(In reply to Richard Tollerton from comment #2)
> Related question: I only care about this because virt-install isn't
> autodetecting --os-variant on an existing disk image (or at least it's not
> documented as doing so). Should I file a bug report with them on this? Or
> are virt-manager dependencies on libguestfs a problem?

Yes, file separate bugs for anything that affects a different component.

Comment 4 Richard W.M. Jones 2015-11-13 11:50:24 UTC

Untested patch posted:
https://www.redhat.com/archives/libguestfs/2015-November/thread.html#00137

Comment 5 Richard Tollerton 2015-11-13 18:47:05 UTC

I have validated the fix in a build from patched master.

Comment 6 Richard W.M. Jones 2015-11-13 18:52:05 UTC

For reference, the correct fix was:
https://www.redhat.com/archives/libguestfs/2015-November/msg00141.html

Comment 7 Richard W.M. Jones 2015-11-13 19:00:11 UTC

Fixed in 1.31.26.