Bug 1282080

Summary: Review Request: blackshades - First person shooter - protect the VIP
Product: [Fedora] Fedora Reporter: Brigham Keys <bkeys>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: anto.trande, bkeys, package-review, rosser.bjr, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AwaitingSubmitter
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-07 09:07:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 177841, 201449, 1364745    

Description Brigham Keys 2015-11-14 19:32:15 UTC
Spec URL: https://github.com/ComradeKeys/blackshadeselite/blob/master/fedora/blackshades.spec
SRPM URL: https://github.com/ComradeKeys/blackshadeselite/blob/master/fedora/blackshades-.9-1.fc21.src.rpm
Description: First person shooter - protect the VIP.
Fedora Account System Username: bkeys

Comment 1 fszymanski 2015-11-14 23:04:42 UTC

SRPM URL should be to the raw file:

Also, at the first glance:
- you should change the version number to 0.9
- full URL of the source archive is missing (Source0 tag)
- no description

Comment 2 Brigham Keys 2015-11-15 20:52:31 UTC
I have:
Changed the number to 0.9
The Source0 tag has the tarball, the url tag has the URL
Wrote the description

I cannot find a raw file in any of the files that RPM build generated. Unless you mean the tar.gz file?

Comment 3 Antonio T. (sagitter) 2015-12-03 14:20:32 UTC
Please, provide SPEC/SRPM links if you still need a package review.

- /usr/bin/%{name}

Use the macros: http://fedoraproject.org/wiki/Packaging:Guidelines#Macros

- Source0: %{name}-%{version}.tar.gz

Where does source code archive come from?


- rm -rf $RPM_BUILD_ROOT


- COPYING is not tagged with %license.


- Decription is too ling for a single line:

Comment 4 Antonio T. (sagitter) 2016-03-09 17:28:22 UTC
Any news here ?