Spec URL: https://github.com/ComradeKeys/blackshadeselite/blob/master/fedora/blackshades.spec SRPM URL: https://github.com/ComradeKeys/blackshadeselite/blob/master/fedora/blackshades-.9-1.fc21.src.rpm Description: First person shooter - protect the VIP. Fedora Account System Username: bkeys
Hi, SRPM URL should be to the raw file: https://github.com/ComradeKeys/blackshadeselite/raw/master/fedora/blackshades-.9-1.fc21.src.rpm Also, at the first glance: - you should change the version number to 0.9 - full URL of the source archive is missing (Source0 tag) - no description
I have: Changed the number to 0.9 The Source0 tag has the tarball, the url tag has the URL Wrote the description I cannot find a raw file in any of the files that RPM build generated. Unless you mean the tar.gz file?
Please, provide SPEC/SRPM links if you still need a package review. - /usr/bin/%{name} Use the macros: http://fedoraproject.org/wiki/Packaging:Guidelines#Macros - Source0: %{name}-%{version}.tar.gz Where does source code archive come from? http://fedoraproject.org/wiki/Packaging:SourceURL - rm -rf $RPM_BUILD_ROOT Useless. - COPYING is not tagged with %license. http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text - Decription is too ling for a single line: https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainers/Common_Rpmlint_Issues#description-line-too-long
Any news here ?