Bug 1283178

Summary:	[GlusterD]: Incorrect peer status showing if volume restart done before entire cluster update.
Product:	[Community] GlusterFS	Reporter:	Vijaikumar Mallikarjuna <vmallika>
Component:	quota	Assignee:	Manikandan <mselvaga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bsrirama, bugs, kaushal, nlevinki, rhs-bugs, sankarshan, sasundar, smohan, vbellur
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	glusterd
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1283035
Clones:	1283187 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:45:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1283035
Bug Blocks:	1248895, 1283187

Comment 1 Vijay Bellur 2015-11-18 12:19:10 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of quota version) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Vijay Bellur 2015-11-18 12:35:02 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of quota version) posted (#2) for review on master by Anand Nekkunti (anekkunt)

Comment 3 Vijay Bellur 2015-11-19 06:04:47 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of quota version) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Vijay Bellur 2015-11-19 10:09:47 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of new quota volinfo option) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Vijay Bellur 2015-12-04 07:10:32 UTC

REVIEW: http://review.gluster.org/12878 (quota: add 'quota-version' to xlator volume_options structure) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 6 Vijay Bellur 2015-12-09 05:29:10 UTC

COMMIT: http://review.gluster.org/12878 committed in master by Raghavendra G (rgowdapp) 
------
commit 988495ef1f8bb737d5edd079dec5635309097a62
Author: vmallika <vmallika>
Date:   Fri Dec 4 12:36:22 2015 +0530

    quota: add 'quota-version' to xlator volume_options structure
    
    Below error is seen in brick log:
    0-vol1-quota: option 'quota-version' is not recognized
    
    So add this option to the volume_options structure of
    marker xlator
    
    Change-Id: I1bd68a537936ee0f9af85dac74f1377f84edb8f4
    BUG: 1283178
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/12878
    Reviewed-by: Manikandan Selvaganesh <mselvaga>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 7 Vijay Bellur 2015-12-09 07:44:30 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of new quota volinfo option) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 8 Vijay Bellur 2015-12-09 17:06:52 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of new quota volinfo option) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 9 Vijay Bellur 2015-12-10 04:52:16 UTC

REVIEW: http://review.gluster.org/12642 (quota: fix backward compatibility of new quota volinfo option) posted (#7) for review on master by Vijay Bellur (vbellur)

Comment 10 Vijay Bellur 2015-12-22 09:30:00 UTC

COMMIT: http://review.gluster.org/12642 committed in master by Atin Mukherjee (amukherj) 
------
commit 105dfa9f562b177a6faf4a0958e6d1b5840cee94
Author: vmallika <vmallika>
Date:   Wed Dec 9 13:13:17 2015 +0530

    quota: fix backward compatibility of new quota volinfo option
    
    quota-version features is implemented for 3.7.6
    please see below patch for more details:
    http://review.gluster.org/#/c/12386
    
    As part of this feature, new volume info option 'quota-version'
    was introduced, this can cause check-sum problem
    when a one of the node in a cluster is upgraded to 3.7.6
    (heterogeneous cluster)
    
    So do a OP_VERSION check when storing this option
    in volume info
    
    Change-Id: Ic5b03a1e3f1236b645a065b1fadee7950307e191
    BUG: 1283178
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/12642
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 13 Niels de Vos 2016-06-16 13:45:21 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user