Bug 1283211
| Summary: | check_host_list() should be more robust | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Cedric Buissart <cbuissar> |
| Component: | ganesha-nfs | Assignee: | Kaleb KEITHLEY <kkeithle> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | mainline | CC: | bugs, cbuissar, jthottan, kkeithle, mzywusko, ndevos, nlevinki, skoduri |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1278900 | Environment: | |
| Last Closed: | 2016-06-16 13:45:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1278900 | ||
| Bug Blocks: | |||
|
Comment 1
Vijay Bellur
2015-11-18 13:47:43 UTC
REVIEW: http://review.gluster.org/12588 (glusterd-ganesha xlator parser for ganesha-ha.conf) posted (#4) for review on master by Cedric Buissart (cedric.buissart) REVIEW: http://review.gluster.org/12588 (glusterd-ganesha xlator parser for ganesha-ha.conf) posted (#5) for review on master by Cedric Buissart (cedric.buissart) REVIEW: http://review.gluster.org/12588 (glusterd-ganesha xlator parser for ganesha-ha.conf) posted (#6) for review on master by Cedric Buissart (cedric.buissart) REVIEW: http://review.gluster.org/12588 (glusterd-ganesha xlator parser for ganesha-ha.conf) posted (#7) for review on master by Cedric Buissart (cedric.buissart) COMMIT: http://review.gluster.org/12588 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit de9c322dfbe5c4f9da65fbe0eef443440eafbbdc Author: Cedric Buissart <cbuissar> Date: Mon Nov 16 15:32:29 2015 +0100 glusterd-ganesha xlator parser for ganesha-ha.conf The current method for parsing ganesha-ha.conf is prone to issues : Before the patch : - no double quote leads to segfault e.g. : HA_CLUSTER_NODES=server1,server2 - no check for comments. e.g. : #HA_CLUSTER_NODES="server1,server2" would be used if preceding the real value This is an attempt to a cleaner parser: 1- factorization of parsing code, creating 1 dedicated, more generic parser 2- double quote are no longer mandatory 3- should not segfault 4- lines are no longer limited to 1024 chars Resolves RHBZ 1283211 Change-Id: I75f11461fe1b84915d1c5cfe945b47bd81abc2b1 BUG: 1283211 Signed-off-by: Cedric Buissart <cbuissar> Reviewed-on: http://review.gluster.org/12588 Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: jiffin tony Thottan <jthottan> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |