Bug 1283948
| Summary: | glupy default CFLAGS conflict with our CFLAGS when --enable-debug is used | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Raghavendra Talur <rtalur> |
| Component: | build | Assignee: | Raghavendra Talur <rtalur> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-16 13:45:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#3) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#4) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/13256 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#5) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#6) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#7) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#8) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#9) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#10) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#11) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#12) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#13) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#14) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#15) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#16) for review on master by Avra Sengupta (asengupt) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#17) for review on master by Avra Sengupta (asengupt) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#18) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#19) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/12707 (build: Filter -D_FORTIFY_SOURCE from CFLAGS) posted (#20) for review on master by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/12707 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 5e65701f2660d1be101da81bffea7721d4f9ece0 Author: Raghavendra Talur <rtalur> Date: Fri Nov 20 16:46:31 2015 +0530 build: Filter -D_FORTIFY_SOURCE from CFLAGS We use python-config to get recommended CFLAGS. It provides -D_FORTIFY_SOURCE=2 by default that conflicts with our --enable-debug option or a developer provided no-optimization option. Hence, filter it out from default CFLAGS. Change-Id: Id80196baeb55415b1ea334e7b17143e56dfbadb3 BUG: 1283948 Co-authored-by: Kaleb S KEITHLEY <kkeithle> Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/12707 Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |
Description of problem: We use python-config in glupy section of configure.ac to get recommended CFLAGS. It provides -D_FORTIFY_SOURCE=2 by default that conflicts with our --enable-debug option which has -O0. How reproducible: Always Steps to Reproduce: 1. use --enable-debug on fedora 23 or RHEL 7 and make sure glupy is enabled during configure. 2. make Actual results: Build fails with error In file included from /usr/include/ctype.h:26:0, from /home/jenkins/glusterfs/xlators/features/glupy/src/glupy.c:11: /usr/include/features.h:330:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] # warning _FORTIFY_SOURCE requires compiling with optimization (-O) Expected results: Build should succeed.