Bug 128416
| Summary: | Not using %find_lang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Saou <matthias> | ||||
| Component: | libexif | Assignee: | Marco Pesenti Gritti <mpg> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | wtogami | ||||
| Target Milestone: | --- | Keywords: | EasyFix | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2004-11-09 11:15:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 123268, 136451 | ||||||
| Attachments: |
|
||||||
Created attachment 102153 [details]
Spec file patch
Ping? One month after the initial report, this EasyFix which even includes a complete patch to the spec and was put in the FC3 Target Tracker list, isn't resolved yet :-/ Did it get missed? Could a quick patch and rebuild take place? (Chris is probably busy with his other bugs at the moment) FWIW, requiring: pkgconfig for the devel subpackage is incorrect - although the devel subpackage provides a .pc file, that does not mean that the devel subpackage requires pkgconfig in order to function. Could this be at least be partly applied before the final FC3 freeze? IMHO, it really is an EasyFix, and if any part of the patch to the spec isn't to the taste of the maintainer, then it can be dropped, I really won't mind. For the pkgconfig Requires: in the devel package, I understand that it isn't typically a mandatory dependency, but I really think it's a good thing if the "usual and recommended" way of recompiling against the software is by using pkgconfig. As an example, gtk2-devel depending on pkgconfig has spared a huge amount of failed builds and bug reports for sure. Of course things can be argued both ways... and I'd argue the other for kernel-sourcecode's dependencies on qt-devel and gtk2-devel for instance, as "make menuconfig" is still quite common... oops, getting OT here :-) Doh! Still not in, and the final freeze has happened. Too bad, expecially since it's an EasyFix... Sorry for the delay :/ I'm going to commit this tomorrow, expect the pkgconfig bit. I applied this one in devel. What was the user visible impact of not using find_lang? To decide if it's worth an FC3 update ... Believe it or not, I'm not even sure. I thought at one point that it was for rpm to skip the install of the language files that didn't match the languages that the system was configured for (languages selection at install time), but practise has proved this wrong, at least on FC. I'll guess I'll go ask jbj out of curiosity. One thing's sure though : It's definitely not worth pushing an errata ;-) Updated in RHEL4 too |
Description of problem: The current libexif package doesn't use the %find_lang to properly color the language files. Version-Release number of selected component (if applicable): libexif-0.5.12-3 Additional info: Attached is a patch to correct this, as well as other minor things : - Remove redundant name in summary - Add pkgconfig dependency to the devel package - Add %{?_smp_mflags} make parameter - Add docs, including the mandatory COPYING file