Bug 1284784

Summary:	NUMA node configuration is updated even if you hit cancel
Product:	[oVirt] ovirt-engine	Reporter:	Roman Mohr <rmohr>
Component:	Frontend.WebAdmin	Assignee:	Roman Mohr <rmohr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Artyom <alukiano>
Severity:	high	Docs Contact:
Priority:	medium
Version:	3.6.0	CC:	bugs, dfediuck, mavital, mgoldboi, rgolan, sbonazzo, ylavi
Target Milestone:	ovirt-3.6.3	Keywords:	Triaged
Target Release:	3.6.3	Flags:	rule-engine: ovirt-3.6.z+ mgoldboi: exception+ mgoldboi: planning_ack+ dfediuck: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Cancel button in the 'NUMA Pinning' dialogue had the same effect as the 'OK' button because when dragging NUMA nodes around the changes were already done on a concrete VM outside of the context of the dialogue Consequence: When dragging NUMA nodes around and clicking 'cancel' the change was silently persisted when saving the VM configuration. Fix: Only manipulate a view which updates the real VM when clicking OK and does nothing when klicking CANCEL. Result: Cancel button works as expected.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-02-18 11:10:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roman Mohr 2015-11-24 08:53:14 UTC

Description of problem:
When entering the numa pinning dialog through VM-Configuration -> Host -> 'Numa pinning' and dragging around the numa nodes, the cancel button has no effect. Clicking 'Cancel' and opening the dialog again still shows the new configuration.

Note that this only happens after you have already persisted the VM configuration with numa nodes at least once.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Configure VM with numa nodes
2. Save VM configuration
3. Edit VM configuration
4. Enter numa pinning dialgo through VM configuration dialog
5. Drag around the numa nodes
6. Click "Cancel" and persiste the VM configuration

Actual results:
Canceled numa configuration changes get persisted


Expected results:
The last saved numa configuration or the last configuration change where 'OK' was clicked in the numa pinning dialog should be persisted.

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2015-11-27 04:24:57 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Red Hat Bugzilla Rules Engine 2015-11-27 04:24:57 UTC

This bug is not marked for z-stream, yet the milestone is for a z-stream version, therefore the milestone has been reset.
Please set the correct milestone or add the z-stream flag.

Comment 3 Red Hat Bugzilla Rules Engine 2015-12-16 21:35:53 UTC

This bug is not marked for z-stream, yet the milestone is for a z-stream version, therefore the milestone has been reset.
Please set the correct milestone or add the z-stream flag.

Comment 4 Artyom 2016-02-01 13:23:14 UTC

Verified on rhevm-webadmin-portal-3.6.3-0.1.el6.noarch