Bug 1285174

Summary:	Create doesn't remember flags it is opened with
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.6	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1285173	Environment:
Last Closed:	2016-04-19 07:49:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1285173
Bug Blocks:

Description Pranith Kumar K 2015-11-25 07:17:51 UTC

+++ This bug was initially created as a clone of Bug #1285173 +++

Description of problem:

We found in code review that create fop is not remembering the flags it comes with. This will lead to failures of the fops once there is a disconnect and reconnect.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2015-11-25 02:16:41 EST ---

REVIEW: http://review.gluster.org/12739 (cluster/afr: Remember flags sent by create fop) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 1 Vijay Bellur 2015-11-25 07:19:41 UTC

REVIEW: http://review.gluster.org/12740 (cluster/afr: Remember flags sent by create fop) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2015-11-26 10:01:04 UTC

COMMIT: http://review.gluster.org/12740 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 748138bc3001de6d29be50c9e72ec1b32cb20625
Author: Pranith Kumar K <pkarampu>
Date:   Wed Nov 25 12:31:25 2015 +0530

    cluster/afr: Remember flags sent by create fop
    
            Backport of http://review.gluster.org/12739
    
    Problem:
    In create fop, afr doesn't remember the flags. When afr has to perform
    fixing of the fd that needs to be opened on other bricks because the brick
    was down at the time of create, the flags with which it needs to send open
    are not present.
    
    Fix:
    Remember the flags in the fd_ctx.
    
    Thanks to Nitya for showing us the problem in re-open with the flags.
    
    BUG: 1285174
    Change-Id: Id203a79896eaa093b035d645fe0fc24d7de71a3a
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/12740
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    Tested-by: Gluster Build System <jenkins.com>

Comment 3 Kaushal 2016-04-19 07:49:12 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report.

glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user