Bug 1285375

Summary:	RHEV Hypervisor custom naming scheme does not check for invalid characters
Product:	Red Hat Quickstart Cloud Installer	Reporter:	Antonin Pagac <apagac>
Component:	Installation - RHEV	Assignee:	dgao
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dave Johnson <dajohnso>
Severity:	unspecified	Docs Contact:	Dan Macpherson <dmacpher>
Priority:	unspecified
Version:	1.0	CC:	arubin, bthurber, dgao, jmatthew
Target Milestone:	TP2	Keywords:	Triaged
Target Release:	1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-03 19:00:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1291836

Description Antonin Pagac 2015-11-25 13:47:22 UTC

Description of problem:
When deploying RHEVM, in step 2C Hypervisors, the host naming scheme 'Custom scheme' does not check for invalid characters in 'Prepend host names with' field. This can cause an invalid hostname to be added and the deployment to fail.

Version-Release number of selected component (if applicable):
RHCI-6.0-RHEL-7-20151118.t.0-RHCI-x86_64-dvd1.iso

How reproducible:
Always

Steps to Reproduce:
1. Start a deployment of RHEVM
2. Go to step 2C Hypervisors, choose naming scheme 'Custom scheme'
3. Fill out some invalid characters in the 'Prepend host names with' field
4. Click Next, no check is performed

Actual results:
No check for invalid characters is performed; user is allowed to continue with invalid characters in hostname

Expected results:
Check for invalid characters; don't allow to continue with invalid characters in hostname

Additional info:

Comment 1 Antonin Pagac 2015-11-25 14:16:19 UTC

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1285393

Comment 2 dgao 2016-01-20 15:12:21 UTC

The UI already has checks against invalid characters in mac naming scheme. When invalid characters are entered, the "Next" button is disabled.

In addition, invalid characters are checked as part of backend validation in the deployment summary screen. The changes can be tracked in: 

https://github.com/fusor/fusor/pull/600

Comment 3 Antonin Pagac 2016-01-26 09:29:53 UTC

Verified.

RHCI-6.0-RHEL-7-20160122.t.1-RHCI-x86_64-dvd1.iso