Bug 1285989

Summary: bitrot: bitrot scrub status command should display the correct value of total number of scrubbed, unsigned file
Product: [Community] GlusterFS Reporter: Gaurav Kumar Garg <ggarg>
Component: bitrotAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact: bugs <bugs>
Priority: unspecified    
Version: mainlineCC: bugs, smohan, vshankar
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1291546 (view as bug list) Environment:
Last Closed: 2016-06-16 13:47:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1291546    

Description Gaurav Kumar Garg 2015-11-27 07:16:58 UTC
Description of problem:

if user execute bitrot scrub status command then it should display correct value of total number of scrubbed file, total number of unsigned file, and last scrub time.

Comment 1 Vijay Bellur 2015-11-27 07:22:00 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Vijay Bellur 2015-11-27 15:57:21 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Vijay Bellur 2015-12-04 03:45:33 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Vijay Bellur 2015-12-04 09:43:14 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Vijay Bellur 2015-12-09 09:15:15 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Vijay Bellur 2015-12-09 09:46:28 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Vijay Bellur 2015-12-09 11:38:21 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#8) for review on master by Gaurav Kumar Garg (ggarg)

Comment 8 Vijay Bellur 2015-12-10 07:18:31 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#9) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Vijay Bellur 2015-12-10 08:45:07 UTC
REVIEW: http://review.gluster.org/12776 (bitrot: getting correct value of scrub stat's) posted (#10) for review on master by Gaurav Kumar Garg (ggarg)

Comment 10 Vijay Bellur 2015-12-15 03:08:43 UTC
COMMIT: http://review.gluster.org/12776 committed in master by Venky Shankar (vshankar) 
------
commit 22827d51c232c44a8f5ac003529d907d93baf7b0
Author: Gaurav Kumar Garg <garg.gaurav52>
Date:   Wed Nov 25 17:38:43 2015 +0530

    bitrot: getting correct value of scrub stat's
    
    When user execute bitrot scrub status command then gluster
    is not giving correct value of Number of Scrubbed files,
    Number of Unsigned files, Last completed scrub time,
    Duration of last scrub.
    
    With this patch scrub status will give correct value for
    all the above fields.
    
    Change-Id: Ic966f76d22db5b0c889e6386a1c2219afbda1f49
    BUG: 1285989
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/12776
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>

Comment 11 Vijay Bellur 2015-12-30 06:24:04 UTC
REVIEW: http://review.gluster.org/13105 (glusterd / cli: mask out inaccurate scrub statistics) posted (#3) for review on master by Venky Shankar (vshankar)

Comment 12 Vijay Bellur 2015-12-30 09:28:58 UTC
REVIEW: http://review.gluster.org/13105 (glusterd/cli: mask out inaccurate scrub statistics) posted (#4) for review on master by Venky Shankar (vshankar)

Comment 13 Vijay Bellur 2016-01-11 10:47:56 UTC
COMMIT: http://review.gluster.org/13105 committed in master by Atin Mukherjee (amukherj) 
------
commit 2a37dbd845348a774f45c4d77cffebc32c749251
Author: Venky Shankar <vshankar>
Date:   Tue Dec 29 10:54:55 2015 +0530

    glusterd/cli: mask out inaccurate scrub statistics
    
    Some of the scrub statistics are inaccurate at the moment and would
    successfully fool users at times. It's best to not display these
    stats and stick to what is accurate.
    
    Note that the change is only in the CLI part - glusterd (and brick)
    supplies _all_ available scrub statistics, but CLI just selectively
    sticks to what needs to be displayed.
    
    Change-Id: Ia99f505a2cb10d5406cd37035d082e593f7e9a8c
    BUG: 1285989
    Signed-off-by: Venky Shankar <vshankar>
    Reviewed-on: http://review.gluster.org/13105
    Reviewed-by: Gaurav Kumar Garg <ggarg>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 14 Kotresh HR 2016-05-03 06:51:48 UTC

*** This bug has been marked as a duplicate of bug 1329211 ***

Comment 16 Niels de Vos 2016-06-16 13:47:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user