Bug 1286461 (eegview)

Summary:	Review Request: eegview - Small program to display/record EEG signals
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-09 20:49:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1286434, 1286444, 1286460
Bug Blocks:	1276941

Description Igor Gnatenko 2015-11-29 18:10:49 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/eegview.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/eegview-0.0-1.fc24.src.rpm
Description:
eegview is a small program to display/record EEG signals. It is particularly
useful for setting up quickly the acquisition part of a offline protocol.
Fedora Account System Username: ignatenkobrain

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-11-30 20:00:40 UTC

- license is OK
- license file is present, %license is used
- desktop file has no MimeType key, so no scriptlet needed
- seems to run fine, alas no hardware to actually test functionality
- you could add a appdata file, although this is a rather niche package so this isn't crucial [https://fedoraproject.org/wiki/Packaging:AppData].
- rpmlint:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package is APPROVED.

Comment 2 Igor Gnatenko 2015-11-30 20:05:11 UTC

What about eegdev?

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-11-30 20:12:37 UTC

Threading error in the review parallelization pipeline. Fixed a few seconds ago :)

Comment 4 Gwyn Ciesla 2015-11-30 20:43:03 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/eegview

Comment 5 Fedora Update System 2015-12-01 06:15:50 UTC

eegview-0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f49cdff3c2

Comment 6 Fedora Update System 2015-12-01 22:30:33 UTC

eegview-0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update eegview'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f49cdff3c2

Comment 7 Fedora Update System 2015-12-09 20:49:45 UTC

eegview-0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.