Bug 1286980

Summary:	Review Request: perl-File-Zglob - Provide extended Unix glob
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-File-Zglob-0.11-1.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-02 07:37:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jitka Plesnikova 2015-12-01 09:37:09 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob-0.11-1.fc24.src.rpm
Description:
Provides a traditional Unix glob(3) functionality; returns a list of
pathnames that matches the given pattern.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-12-01 11:42:45 UTC

* What's the reason for line 41?  The only executable file is author/test.pl;
  why would you care about it?

* Missing some BRs
  - coreutils, `rm' on line 39, `chmod' on line 41
  - sed, `sed' line 40

* The summary is very brief but acceptable.  However, I would correct the
  grammar in the description: s/matches/match/

* The package attempts to run the author tests (xt/*).  They're all skipped
  because of the missing dependencies but this could lead to an unexpected
  FTBFS if some of them make it into the buildroot.
  Either disable them (removing the author_test() call from Makefile.PL
  should work) or declare the missing optional BRs.

Comment 2 Jitka Plesnikova 2015-12-01 12:52:56 UTC

(In reply to Petr Šabata from comment #1)
> * What's the reason for line 41?  The only executable file is author/test.pl;
>   why would you care about it?
It was just for prevention. Removed it.
 
> * Missing some BRs
>   - coreutils, `rm' on line 39, `chmod' on line 41
>   - sed, `sed' line 40
Added.

> * The summary is very brief but acceptable.  However, I would correct the
>   grammar in the description: s/matches/match/
Updated

> * The package attempts to run the author tests (xt/*).  They're all skipped
>   because of the missing dependencies but this could lead to an unexpected
>   FTBFS if some of them make it into the buildroot.
>   Either disable them (removing the author_test() call from Makefile.PL
>   should work) or declare the missing optional BRs.
Disabled author_test.

Updated files are on the same link

Comment 3 Petr Šabata 2015-12-01 13:05:42 UTC

(In reply to Jitka Plesnikova from comment #2)
> (In reply to Petr Šabata from comment #1)
> > * What's the reason for line 41?  The only executable file is author/test.pl;
> >   why would you care about it?
> It was just for prevention. Removed it.

Okay.

> > * Missing some BRs
> >   - coreutils, `rm' on line 39, `chmod' on line 41
> >   - sed, `sed' line 40
> Added.

Ack.

> > * The summary is very brief but acceptable.  However, I would correct the
> >   grammar in the description: s/matches/match/
> Updated

Ack.

> > * The package attempts to run the author tests (xt/*).  They're all skipped
> >   because of the missing dependencies but this could lead to an unexpected
> >   FTBFS if some of them make it into the buildroot.
> >   Either disable them (removing the author_test() call from Makefile.PL
> >   should work) or declare the missing optional BRs.
> Disabled author_test.

Ack.

Approving.

Comment 4 Gwyn Ciesla 2015-12-01 13:34:21 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-File-Zglob

Comment 5 Jitka Plesnikova 2015-12-02 07:37:37 UTC

Thank you for the review and the repository.