Spec URL: https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-File-Zglob/perl-File-Zglob-0.11-1.fc24.src.rpm Description: Provides a traditional Unix glob(3) functionality; returns a list of pathnames that matches the given pattern. Fedora Account System Username: jplesnik
* What's the reason for line 41? The only executable file is author/test.pl; why would you care about it? * Missing some BRs - coreutils, `rm' on line 39, `chmod' on line 41 - sed, `sed' line 40 * The summary is very brief but acceptable. However, I would correct the grammar in the description: s/matches/match/ * The package attempts to run the author tests (xt/*). They're all skipped because of the missing dependencies but this could lead to an unexpected FTBFS if some of them make it into the buildroot. Either disable them (removing the author_test() call from Makefile.PL should work) or declare the missing optional BRs.
(In reply to Petr Šabata from comment #1) > * What's the reason for line 41? The only executable file is author/test.pl; > why would you care about it? It was just for prevention. Removed it. > * Missing some BRs > - coreutils, `rm' on line 39, `chmod' on line 41 > - sed, `sed' line 40 Added. > * The summary is very brief but acceptable. However, I would correct the > grammar in the description: s/matches/match/ Updated > * The package attempts to run the author tests (xt/*). They're all skipped > because of the missing dependencies but this could lead to an unexpected > FTBFS if some of them make it into the buildroot. > Either disable them (removing the author_test() call from Makefile.PL > should work) or declare the missing optional BRs. Disabled author_test. Updated files are on the same link
(In reply to Jitka Plesnikova from comment #2) > (In reply to Petr Šabata from comment #1) > > * What's the reason for line 41? The only executable file is author/test.pl; > > why would you care about it? > It was just for prevention. Removed it. Okay. > > * Missing some BRs > > - coreutils, `rm' on line 39, `chmod' on line 41 > > - sed, `sed' line 40 > Added. Ack. > > * The summary is very brief but acceptable. However, I would correct the > > grammar in the description: s/matches/match/ > Updated Ack. > > * The package attempts to run the author tests (xt/*). They're all skipped > > because of the missing dependencies but this could lead to an unexpected > > FTBFS if some of them make it into the buildroot. > > Either disable them (removing the author_test() call from Makefile.PL > > should work) or declare the missing optional BRs. > Disabled author_test. Ack. Approving.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-File-Zglob
Thank you for the review and the repository.