Bug 1287450

Summary: RFE: qterminal compiled against Qt5.x
Product: [Fedora] Fedora Reporter: Ali Akcaagac <aliakc>
Component: qterminalAssignee: Eugene A. Pivnev <ti.eugene>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: helio, ti.eugene
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qterminal-0.6.0-4.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-28 23:54:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
New qterminal spec none

Description Ali Akcaagac 2015-12-02 06:30:21 UTC
I like to request a feature enchancement for qterminal to be compiled and linked against Qt5. As I googled, qterminal seems to be ported to Qt5 already. I ask for this because of lxqt. lxqt 0.10 links and supports Qt5 already and qterminal (which seem to be the default terminal for lxqt so far) is still linked against Qt4 and thus pulls in all the Qt4 requirements. This is unnecessary and a overload in case someone likes to set up a minimal system.

Comment 1 Helio Chissini de Castro 2015-12-02 10:50:08 UTC
Ack confirmed.

Was my fault. will be soon fixed.

Comment 2 Eugene A. Pivnev 2015-12-02 17:10:40 UTC
(In reply to Ali Akcaagac from comment #0)
> I like to request a feature enchancement for qterminal to be compiled and
> linked against Qt5. As I googled, qterminal seems to be ported to Qt5
> already.

Not fully right.
qterminal uses libqxt-devel (qt4 only):

if(USE_QT5 AND USE_SYSTEM_QXT)
    message(FATAL_ERROR "Unable to use system qxt with qt5 now")
endif()

As Fedora policy disallows to use bundled 3-rd parties - please ask libqxt maintainers to make qt5-version of libqxt.
As qxt is EOL (https://bitbucket.org/libqxt/libqxt/wiki/Home) they can use qxt from qterminal sources (something like qxt-0.7.0).

Then I'll can make qt5-version of qterminal.

Comment 3 Ali Akcaagac 2015-12-02 17:55:59 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1287806

Comment 4 Helio Chissini de Castro 2015-12-02 19:10:46 UTC
Eugene, i have it ready.
I'm attaching the new spec, but i can commit and build right now. Can you approve my ACL's

And yes, we can use the bundled one, since qxt is not anymore developed outside, it lives only on the lxqt qterminal code.

[]'s Helio

Comment 5 Eugene A. Pivnev 2015-12-03 10:25:51 UTC
Please try it: https://koji.fedoraproject.org/koji/taskinfo?taskID=12037365
If ok - I'll push it into Bodhi

Comment 6 Helio Chissini de Castro 2015-12-03 10:53:19 UTC
Hello

Yes, it works, but i would like to update all distros till f22, that's why i opened a request to co-maintain the package.

As i'm already dealing with lxqt, it will be more easy when i do updates to avoid it.

Is it possible ?

Regards, Helio

Comment 7 Helio Chissini de Castro 2015-12-03 19:44:03 UTC
Created attachment 1101953 [details]
New qterminal spec

This is the final spec to only qt5 qterminal

Comment 8 Helio Chissini de Castro 2015-12-03 19:45:15 UTC
So, i attached the proper spec, that match all current lxqt builds.

Since i can't have rights, Eugene, you can use it and please compile against rawhide, f23, f22 ?

Regards

Comment 9 Fedora Update System 2015-12-05 10:41:19 UTC
qterminal-0.6.0-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-9191229506

Comment 10 Eugene A. Pivnev 2015-12-05 10:44:13 UTC
(In reply to Helio Chissini de Castro from comment #8)
> So, i attached the proper spec, that match all current lxqt builds.
> 
> Since i can't have rights, Eugene, you can use it and please compile against
> rawhide, f23, f22 ?
> 
> Regards

qt5-only qterminal is racism :-)
Test new release from testing repo.
Qt5 version is qterminal-qt5 package.

Comment 11 Ali Akcaagac 2015-12-05 19:58:42 UTC
Well if the package's name is "qterminal-qt5" then it might be interesting to adjust the meta package as well, so in case of a:

dnf group install lxqt

pulls in the qterminal-qt5 thingy rather than the qt4 one.

Comment 12 Fedora Update System 2015-12-06 05:22:14 UTC
qterminal-0.6.0-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update qterminal'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-9191229506

Comment 13 Ali Akcaagac 2015-12-07 18:53:48 UTC
Please don't forget to adjust the lxqt group to pull in qterminal-qt5 rather than qterminal (which relies on qt4).

Comment 14 Helio Chissini de Castro 2015-12-07 19:26:24 UTC
Fix done for comps ( group ).

[]'s

Comment 15 Ali Akcaagac 2015-12-16 19:37:58 UTC
Is it possible to get that comps change for F22 as well ?

Comment 16 Fedora Update System 2015-12-28 23:54:49 UTC
qterminal-0.6.0-4.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.