Bug 1287560

Summary:	Data Tiering:Don't allow or reset the frequency threshold values to zero when record counter features.record-counter is turned off
Product:	[Community] GlusterFS	Reporter:	Joseph Elwin Fernandes <josferna>
Component:	tiering	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.7.6	CC:	bugs, dlambrig, nchilaka, rcyriac, sankarshan
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1286346	Environment:
Last Closed:	2016-04-19 07:49:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1284067, 1286346
Bug Blocks:

Comment 1 Vijay Bellur 2015-12-02 11:00:39 UTC

REVIEW: http://review.gluster.org/12849 (tier/glusterd : Validation for frequency thresholds and record-counters) posted (#1) for review on release-3.7 by Joseph Fernandes

Comment 2 Vijay Bellur 2015-12-02 19:47:21 UTC

COMMIT: http://review.gluster.org/12849 committed in release-3.7 by Dan Lambright (dlambrig) 
------
commit 06b7ca1dcd7f3c3187e83a17fad7224d661b4d7e
Author: Joseph Fernandes <josferna>
Date:   Sat Nov 28 17:03:41 2015 +0530

    tier/glusterd : Validation for frequency thresholds and record-counters
    
    1) if record-counters is set to off
       check if both the frequency thresholds are non-zero, then pop
       an error message, with volume set failed.
    2) if record-counters is set to on
       check if both the frequency thresholds are zero, then pop
       an note, but volume set is not failed.
    3) If any of the frequency thresholds are set to a non-zero value,
       switch record-counters on, if not already on
    4) If both the frequency thresholds are set to zero,
       switch record-counters off, if not already off
    
    NOTE: In this fix we have
    1) removed unnecessary ctr vol set options.
    2) changed  ctr_hardlink_heal_expire_period to ctr_lookupheal_link_timeout
    
    Backport of  http://review.gluster.org/12780
    
    > Change-Id: Ie7ccfd3f6e021056905a79de5a3d8f199312f315
    > BUG: 1286346
    > Signed-off-by: Joseph Fernandes <josferna>
    > Signed-off-by: Dan Lambright <dlambrig>
    > Reviewed-on: http://review.gluster.org/12780
    > Tested-by: Gluster Build System <jenkins.com>
    > Tested-by: NetBSD Build System <jenkins.org>
    > Signed-off-by: Joseph Fernandes <josferna>
    
    Change-Id: I35621ed3cc1ad20a75ef16e0b95453b8c6120852
    BUG: 1287560
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/12849
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>

Comment 3 Kaushal 2016-04-19 07:49:44 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.7, please open a new bug report.

glusterfs-3.7.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-February/025292.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user