Bug 1287637

Summary:	Pressing Save or Reset in Advanced Config disables buttons permanently
Product:	Red Hat CloudForms Management Engine	Reporter:	Dan Clarizio <dclarizi>
Component:	UI - OPS	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED ERRATA	QA Contact:	luke couzens <lcouzens>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.5.0	CC:	cpelland, hkataria, jhardy, jprause, mpovolny, obarenbo
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.6.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1288191 (view as bug list)		Environment:
Last Closed:	2016-06-29 15:15:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1288191

Description Dan Clarizio 2015-12-02 13:17:57 UTC

Description of problem:
Save/Reset buttons turn on when first using the Advanced Config form, but are disabled if a change is saved or reset.  The buttons no longer become enabled when typing changes in.

Version-Release number of selected component (if applicable):
5.5.0

How reproducible:
Make changes in advanced config, save/reset, try to make more changes

Actual results:
Buttons stay disabled

Expected results:
Buttons enabled when changes are made

Additional info:
Discovered when testing https://github.com/ManageIQ/manageiq/pull/5656

Comment 2 Dávid Halász 2015-12-02 15:54:18 UTC

https://github.com/ManageIQ/manageiq/pull/5682

Comment 3 CFME Bot 2015-12-07 14:48:23 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/666490053b83845b7b983ebba74f8ed0bbabec6b

commit 666490053b83845b7b983ebba74f8ed0bbabec6b
Author:     Dávid Halász <dhalasz>
AuthorDate: Wed Dec 2 16:38:38 2015 +0100
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Dec 7 13:55:18 2015 +0100

    Fixed onchange enabling of save/reset buttons in ops codemirror
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1287637

 app/controllers/ops_controller.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 4 CFME Bot 2015-12-07 18:43:28 UTC

New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f18e42a87762cf0c43c1478183f4bde91620a34e

commit f18e42a87762cf0c43c1478183f4bde91620a34e
Author:     Dávid Halász <dhalasz>
AuthorDate: Wed Dec 2 16:38:38 2015 +0100
Commit:     Dávid Halász <dhalasz>
CommitDate: Mon Dec 7 15:54:07 2015 +0100

    Fixed onchange enabling of save/reset buttons in ops codemirror
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1287637
    Clean cherrypick from: https://github.com/ManageIQ/manageiq/pull/5682
    (cherry picked from commit 666490053b83845b7b983ebba74f8ed0bbabec6b)

 app/controllers/ops_controller.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comment 5 luke couzens 2016-04-18 13:05:18 UTC

Verified in 5.6.0.1-beta2

Comment 7 errata-xmlrpc 2016-06-29 15:15:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348