Bug 1289717 (viennacl)

Because I am owner of whole OpenCL stack - I will review this.

> Group:         Development/Libraries
not needed

> ctest -VV ||:
Ignoring tests without informing upstream and without any comments is very bad.\

>-DBUILD_EXAMPLES=ON \
but you are not including examples... Please add new doc subpackage and include examples and some documentation.

> [brain@x1carbon ViennaCL-1.7.0]$ find ./CL/
./CL/
./CL/cl.hpp
./CL/cl_platform.h
./CL/cl_gl_ext.h
./CL/cl_gl.h
./CL/opencl.h
./CL/cl.h
./CL/cl_ext.h
./CL/cl_d3d10.h

You MUST remove bundled opencl-headers.

Looks like you also need to install pocl into buildroot... 

Not approved.

New Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec
New SRPM URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.0-2.fc23.src.rpm

tests: http://sourceforge.net/p/viennacl/mailman/message/34697733/

Please put BuildRequires (and other tags) with one package per line. This makes things much easier to read (and diffs look better too).

Package looks good, but it seems that it doesn't make sense to release without the fixes queued for 1.7.1.

New version 1.7.1
Spec URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec
SRPM URL: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-1.fc24.src.rpm

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/viennacl

Retired, untagged all builds, review not approved.

Ilya, what happened here? Do you still plan to package this?

Hi Zbigniew,

It was my mistake. How can I regain package on:
************
https://admin.fedoraproject.org/pkgdb/package/rpms/viennacl/
************

I just needs to go through review.

I realized  is necessary to make a new review?

Now I have it:
*******
fedpkg clone viennacl && cd viennacl && ls --> dead.package
*******

The review sets the review? flag.

(In reply to Ilya Gradina from comment #11)
> I realized  is necessary to make a new review?
No, just this one needs to be finished. I'll do it, unless Igor wants to do it.

> Now I have it:
> *******
> fedpkg clone viennacl && cd viennacl && ls --> dead.package
> *******
Yeah, you'll have to file a ticket to get the package unretired.

Sorry, I do not know how me  file a ticket to get the package unretired.

> Request unretirement in Package Database by selecting the package and clicking 
> "Ask unretirement" button. Specify all branches that need to be un-retired 
> (inlcuding "master" for Rawhide, unless it is for EPEL only) and include the 
> link to re-review. 

from https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package

Igor, do you want to finish the review?

(In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> Igor, do you want to finish the review?

Yes, I will do review in Monday.

quick notes: remove magic numbers.

* Don't build examples as you don't really package it (you can put source code of them in -devel subpackage if it's not huge amount of data) and remove examples subpackage
* Remove all magic numbers and if you need to exclude some test, write link to upstream bugreport
* Own %dir %{_datadir}/cmake
* Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes, then License should look like "MIT and ISC"
* drop bundled opencl headers and use system ones from opencl-headers

(In reply to Igor Gnatenko from comment #17)
> * drop bundled opencl headers and use system ones from opencl-headers
Ignore this one, it's already done.

(In reply to Igor Gnatenko from comment #17)
> * Don't build examples as you don't really package it (you can put source
> code of them in -devel subpackage if it's not huge amount of data) and
> remove examples subpackage
> * Remove all magic numbers and if you need to exclude some test, write link
> to upstream bugreport
> * Own %dir %{_datadir}/cmake
> * Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes,
> then License should look like "MIT and ISC"
> * drop bundled opencl headers and use system ones from opencl-headers

Hi Igor,

thx!

new spec: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec
new srpm: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-2.fc26.src.rpm

new spec: https://github.com/neurofedora/ViennaCL/raw/master/viennacl.spec
new srpm: https://github.com/neurofedora/ViennaCL/raw/master/viennacl-1.7.1-3.fc26.src.rpm

- fix license
- fix path cmake
- fix tests

viennacl-1.7.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4

viennacl-1.7.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90

@Ilya Please build for rawhide also

viennacl-1.7.1-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4

viennacl-1.7.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90

viennacl-1.7.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90

viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4

(In reply to Sandro Mani from comment #23)
> @Ilya Please build for rawhide also

sorry but I can not yet.
https://pagure.io/releng/issue/6555

viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

viennacl-1.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

viennacl-1.7.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.