Bug 1289940
Summary: | [libosmocore] Fix test on big-endian machines | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rafael Fonseca <rdossant> | ||||||
Component: | libosmocore | Assignee: | Jaroslav Škarvada <jskarvad> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | jskarvad | ||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||
Target Release: | --- | ||||||||
Hardware: | ppc64 | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | libosmocore-0.9.0-3.20151109git916423ef.fc23 libosmocore-0.9.0-3.20151109git916423ef.fc22 libosmocore-0.9.0-3.20151109git916423ef.el7 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2016-01-04 18:52:07 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 1071880 | ||||||||
Attachments: |
|
I am afraid this is not the correct fix. The correct way is to fix the library, not patching the test to only hide the problem. The issue is currently discussed upstream. Created attachment 1104088 [details]
Upstream proposed fix
I am afraid that using bitfields is not portable. I think that macros and bitmasks should be used. I pointed this upstream, but I am using the fix for now.
libosmocore-0.9.0-3.20151109git916423ef.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1619da728a libosmocore-0.9.0-3.20151109git916423ef.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f2da169de3 libosmocore-0.9.0-3.20151109git916423ef.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-da529ef26f libosmocore-0.9.0-3.20151109git916423ef.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update libosmocore' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-da529ef26f libosmocore-0.9.0-3.20151109git916423ef.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libosmocore' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1619da728a libosmocore-0.9.0-3.20151109git916423ef.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libosmocore' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-f2da169de3 libosmocore-0.9.0-3.20151109git916423ef.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. libosmocore-0.9.0-3.20151109git916423ef.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. libosmocore-0.9.0-3.20151109git916423ef.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1103842 [details] Fix test on big-endian Description of problem: test fails on big-endian machines because of the way bit-fields are allocated in these architectures. Version-Release number of selected component (if applicable): 0.9.0-2 How reproducible: always on koji-ppc. Additional info: Patch attached.