Bug 1289979

Summary:	Review Request: rbm - Reproducible Build Manager
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, panemade, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rbm-0.4-1.20151206gitd50b2a6.fc24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-01-12 07:42:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-12-09 13:06:59 UTC

Spec URL: https://ppisar.fedorapeople.org/rbm/rbm.spec
SRPM URL: https://ppisar.fedorapeople.org/rbm/rbm-0.4-1.20151206gitd50b2a6.fc24.src.rpm
Description:
Reproducible Build Manager (rbm) is a tool that helps you create and build
packages for multiple linux distributions, and automate the parts that can be
automated. It includes options to run the build in a defined environment to
allow reproducing the build.

Fedora Account System Username: ppisar

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-01-09 17:42:42 UTC

It's a pleasure to read a spec file like this.

+ license is OK (CC0)
+ license file is present, %license is used
+ name is OK
+ latest version (git snapshot)
+ provides and requires seem OK
+ builds and installs OK
+ fs layout follows the guidelines
+ no scriptlets necessary or present
+ fedora-review is happy

Rpmlint (installed packages)
----------------------------
rbm.noarch: W: spelling-error %description -l en_US linux -> Linux
Hm, maybe.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Maybe change "make ... %{?_smp_mflags}" → "%make_build ...".

Package is APPROVED.

Comment 2 Gwyn Ciesla 2016-01-11 19:35:22 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rbm

Comment 3 Petr Pisar 2016-01-12 07:42:13 UTC

Thank you for the review and the repository.

I corrected the typos.