Bug 1289979 - Review Request: rbm - Reproducible Build Manager
Summary: Review Request: rbm - Reproducible Build Manager
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-09 13:06 UTC by Petr Pisar
Modified: 2016-01-12 07:42 UTC (History)
3 users (show)

Fixed In Version: rbm-0.4-1.20151206gitd50b2a6.fc24
Clone Of:
Environment:
Last Closed: 2016-01-12 07:42:13 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2015-12-09 13:06:59 UTC
Spec URL: https://ppisar.fedorapeople.org/rbm/rbm.spec
SRPM URL: https://ppisar.fedorapeople.org/rbm/rbm-0.4-1.20151206gitd50b2a6.fc24.src.rpm
Description:
Reproducible Build Manager (rbm) is a tool that helps you create and build
packages for multiple linux distributions, and automate the parts that can be
automated. It includes options to run the build in a defined environment to
allow reproducing the build.

Fedora Account System Username: ppisar

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-01-09 17:42:42 UTC
It's a pleasure to read a spec file like this.

+ license is OK (CC0)
+ license file is present, %license is used
+ name is OK
+ latest version (git snapshot)
+ provides and requires seem OK
+ builds and installs OK
+ fs layout follows the guidelines
+ no scriptlets necessary or present
+ fedora-review is happy

Rpmlint (installed packages)
----------------------------
rbm.noarch: W: spelling-error %description -l en_US linux -> Linux
Hm, maybe.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Maybe change "make ... %{?_smp_mflags}" → "%make_build ...".

Package is APPROVED.

Comment 2 Gwyn Ciesla 2016-01-11 19:35:22 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rbm

Comment 3 Petr Pisar 2016-01-12 07:42:13 UTC
Thank you for the review and the repository.

I corrected the typos.


Note You need to log in before you can comment on or make changes to this bug.