Bug 1290338

Summary: [Director] pxe_ucs Ironic drivers not working
Product: Red Hat OpenStack Reporter: Anand Nande <anande>
Component: os-cloud-configAssignee: Dmitry Tantsur <dtantsur>
Status: CLOSED CURRENTRELEASE QA Contact: mlammon
Severity: high Docs Contact:
Priority: high    
Version: 7.0 (Kilo)CC: aschultz, asoni, bfournie, bnemec, dcain, dmacpher, jason.dobies, jjoyce, jmelvin, jraju, jschluet, jslagle, lmartins, mburns, nalmond, rhel-osp-director-maint, rhos-docs, rkharya, rtweed, srevivo, vcojot
Target Milestone: ---Keywords: OtherQA, Reopened, Triaged, ZStream
Target Release: 8.0 (Liberty)   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1274579
: 1417302 (view as bug list) Environment:
Last Closed: 2018-09-11 20:37:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1440781, 1440782    

Comment 2 Dan Macpherson 2016-03-13 23:12:16 UTC 
It looks like os-cloud-config is mapping pm_addr to ucs_hostname:

https://github.com/openstack/os-cloud-config/blob/master/os_cloud_config/nodes.py#L84

However, in ironic, the ucs_helper requires ucs_address to be set. There doesn't seem to be a param called ucs_hostname anymore:

https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ucs/helper.py#L97

Got a report of this happening in https://bugzilla.redhat.com/show_bug.cgi?id=1274579
Comment 5 Lucas Alvares Gomes 2016-03-24 16:18:40 UTC 
(In reply to Dan Macpherson from comment #2)
> It looks like os-cloud-config is mapping pm_addr to ucs_hostname:
> 
> https://github.com/openstack/os-cloud-config/blob/master/os_cloud_config/
> nodes.py#L84
> 
> However, in ironic, the ucs_helper requires ucs_address to be set. There
> doesn't seem to be a param called ucs_hostname anymore:
> 
> https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ucs/
> helper.py#L97
> 
> Got a report of this happening in
> https://bugzilla.redhat.com/show_bug.cgi?id=1274579

Right, that seems to be the problem indeed. I'm reassign this bug to the os-cloud-config component since the error is there.
Comment 6 Mike Burns 2016-04-07 21:00:12 UTC 
This bug did not make the OSP 8.0 release.  It is being deferred to OSP 10.
Comment 12 Lucas Alvares Gomes 2016-09-15 12:41:36 UTC 
FWIW I've upload a fix for this upstream: https://review.openstack.org/#/c/370773/
Comment 13 Lucas Alvares Gomes 2016-09-15 15:09:05 UTC 
Backported to rhosp8 and 9 as well
Comment 15 Jeremy 2016-12-21 19:57:11 UTC 
https://github.com/openstack/os-cloud-config/blob/stable/newton/os_cloud_config/nodes.py

Newton still seems to be ucs_hostname and not ucs_address in spite of https://review.openstack.org/#/c/370773/2/os_cloud_config/nodes.py

(Not in master either) , seems the patch did not make it so we should re-open this BZ.
Comment 17 Dmitry Tantsur 2017-10-20 10:28:14 UTC 
Moving to 8. I've prepared downstream backports for both 8 and 9, but I will need OtherQA on them.
Comment 18 Dmitry Tantsur 2017-10-20 11:31:52 UTC 
*** Bug 1417302 has been marked as a duplicate of this bug. ***