Bug 1291081 (php-wikimedia-composer-merge-plugin)

Summary: Review Request: php-wikimedia-composer-merge-plugin - Composer plugin to merge multiple composer.json files
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-18 21:14:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2015-12-13 14:31:07 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/291a4af0dcc5993e2151c115c732ec2365eeb372/php-wikimedia-composer-merge-plugin/php-wikimedia-composer-merge-plugin.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-wikimedia-composer-merge-plugin-1.3.0-1.fc23.src.rpm

Description:
Merge one or more additional composer.json files at runtime.


Fedora Account System Username: siwinski
Comment 1 Upstream Release Monitoring 2015-12-14 08:01:46 UTC 
remi's scratch build of php-wikimedia-composer-merge-plugin-1.3.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12180252
Comment 2 Remi Collet 2015-12-14 08:09:50 UTC 
Created attachment 1105511 [details]
phpci.log

phpCompatInfo version 5.0.0 DB built Dec 10 2015 07:13:14 CET static analyze results
Comment 3 Remi Collet 2015-12-14 08:10:23 UTC 
Created attachment 1105512 [details]
review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Comment 4 Remi Collet 2015-12-14 08:11:46 UTC 
No blocker

[?]: Package functions as described.

	How composer (RPM) will be aware of this plugin ?
	Shouldn't we add somtheing in composer autoloader ?
	e.g.:
  	  foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file)
             require_once $file;
Comment 5 Shawn Iwinski 2015-12-15 02:45:04 UTC 
(In reply to Remi Collet from comment #4)
> No blocker
> 
> [?]: Package functions as described.
> 
> 	How composer (RPM) will be aware of this plugin ?
> 	Shouldn't we add somtheing in composer autoloader ?
> 	e.g.:
>   	  foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file)
>              require_once $file;

Very good point.  I'll do some investigation.
Comment 6 Shawn Iwinski 2015-12-18 21:14:49 UTC 
(In reply to Shawn Iwinski from comment #5)
> (In reply to Remi Collet from comment #4)
> > No blocker
> > 
> > [?]: Package functions as described.
> > 
> > 	How composer (RPM) will be aware of this plugin ?
> > 	Shouldn't we add somtheing in composer autoloader ?
> > 	e.g.:
> >   	  foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file)
> >              require_once $file;
> 
> Very good point.  I'll do some investigation.

I couldn't "quickly" find a solution to this because it seems the only plugin "registration" is done at update/install time.  I am going to close this review request.  If I find a solution to have this packaged in the future I will re-open.