Spec URL: https://raw.githubusercontent.com/siwinski/rpms/291a4af0dcc5993e2151c115c732ec2365eeb372/php-wikimedia-composer-merge-plugin/php-wikimedia-composer-merge-plugin.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-wikimedia-composer-merge-plugin-1.3.0-1.fc23.src.rpm Description: Merge one or more additional composer.json files at runtime. Fedora Account System Username: siwinski
remi's scratch build of php-wikimedia-composer-merge-plugin-1.3.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12180252
Created attachment 1105511 [details] phpci.log phpCompatInfo version 5.0.0 DB built Dec 10 2015 07:13:14 CET static analyze results
Created attachment 1105512 [details] review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
No blocker [?]: Package functions as described. How composer (RPM) will be aware of this plugin ? Shouldn't we add somtheing in composer autoloader ? e.g.: foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file) require_once $file;
(In reply to Remi Collet from comment #4) > No blocker > > [?]: Package functions as described. > > How composer (RPM) will be aware of this plugin ? > Shouldn't we add somtheing in composer autoloader ? > e.g.: > foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file) > require_once $file; Very good point. I'll do some investigation.
(In reply to Shawn Iwinski from comment #5) > (In reply to Remi Collet from comment #4) > > No blocker > > > > [?]: Package functions as described. > > > > How composer (RPM) will be aware of this plugin ? > > Shouldn't we add somtheing in composer autoloader ? > > e.g.: > > foreach (glob(__DIR__.'/autoload-plugin-*.php') as $file) > > require_once $file; > > Very good point. I'll do some investigation. I couldn't "quickly" find a solution to this because it seems the only plugin "registration" is done at update/install time. I am going to close this review request. If I find a solution to have this packaged in the future I will re-open.