Bug 1293293

Summary:	afr: warn if pending xattrs missing during init()
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1293536 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:51:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1293536

Description Ravishankar N 2015-12-21 10:57:02 UTC

Description of problem:

Since commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a
glusterfs-3.7.7), the afr pending xattrs are stored in the volfile and used
by afr when it initializes. If a cluster is upgraded to 3.7.7 and the volfile is not regenerated, AFR will crash.


How reproducible:
Always

Steps to Reproduce:
1. Create a 1x2 replica on glusterfs 3.7.6 on one node
2. Upgrade to 3.7.7, restart glusterd
3. gluster volume set all cluster.op-version 30707
4. start the volume and fuse mount it.

Actual results:
Fuse mount will crash

Expected results:
Should not crash

Comment 1 Vijay Bellur 2015-12-21 10:58:26 UTC

REVIEW: http://review.gluster.org/13038 (afr: warn if pending xattrs missing during init()) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Vijay Bellur 2015-12-21 15:06:45 UTC

REVIEW: http://review.gluster.org/13038 (afr: warn if pending xattrs missing during init()) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 3 Vijay Bellur 2015-12-22 04:31:00 UTC

COMMIT: http://review.gluster.org/13038 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 4bfbabfdd698e93a1dc1aad5590ed18f10936c55
Author: Ravishankar N <ravishankar>
Date:   Mon Dec 21 10:09:53 2015 +0000

    afr: warn if pending xattrs missing during init()
    
    Since commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a
    (glusterfs-3.7.7), the afr pending xattrs are stored in the volfile and used
    by afr when it initializes. If a cluster is upgraded, prevent afr from loading
    until the op-version has been bumped up to 3.7.7 and the volfiles have been
    regenerated using a volume set command.
    
    Without this fix, AFR will crash when initialzing.
    
    Change-Id: I14249dedb3f2f77cd754d78d8a9a70fdc5fc8c10
    BUG: 1293293
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/13038
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 4 Niels de Vos 2016-06-16 13:51:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user