Bug 1293558

Summary: gluster cli crashed while performing 'gluster vol bitrot <vol_name> scrub status'
Product: [Community] GlusterFS Reporter: Gaurav Kumar Garg <ggarg>
Component: bitrotAssignee: Satish Mohan <smohan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact: bugs <bugs>
Priority: urgent    
Version: mainlineCC: amukherj, bugs, byarlaga, knarra, rmekala, sankarshan, smohan, vshankar
Target Milestone: ---Keywords: Reopened, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1292705 Environment:
Last Closed: 2016-06-16 13:51:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1292705    
Bug Blocks:    

Comment 1 Vijay Bellur 2015-12-22 06:48:22 UTC
REVIEW: http://review.gluster.org/13060 (cli: should not dereference NULL pointer while printing bitrot scrub status) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Vijay Bellur 2015-12-22 07:08:34 UTC
REVIEW: http://review.gluster.org/13060 (cli: should not dereference NULL pointer while printing bitrot scrub status) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Vijay Bellur 2015-12-22 07:25:05 UTC
REVIEW: http://review.gluster.org/13060 (cli: should not dereference NULL pointer while printing bitrot scrub status) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Vijay Bellur 2015-12-28 14:59:27 UTC
COMMIT: http://review.gluster.org/13060 committed in master by Atin Mukherjee (amukherj) 
------
commit e4de816ae126b62906afcc1ce1216500b517e222
Author: Gaurav Kumar Garg <garg.gaurav52>
Date:   Tue Dec 22 12:05:39 2015 +0530

    cli: should not dereference NULL pointer while printing bitrot scrub status
    
    When user execute bitrot scrub status command and scrubber is
    pending to do scrubbing then value of last_scrub time will be NULL.
    Currently cli is dereferencing NULL pointer in this case, That might
    lead to crash.
    
    Fix is to use proper check condition while printing scrub status.
    
    Change-Id: I3c4be8e25d089451c6ab77b16737c01d0348ee70
    BUG: 1293558
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/13060
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 7 Niels de Vos 2016-06-16 13:51:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user