Bug 1294078

SRPM link missed here.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-json-diff/nodejs-json-diff.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-json-diff/nodejs-json-diff-0.3.1-1.fc24.src.rpm

hm, fedora-review tool can't find npm(cli-color). Let's wait for it.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
     unknown license. Detailed output of licensecheck in
     /home/parag/1294078-nodejs-json-diff/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.2.14 starting (python version = 3.4.3)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.14
INFO: Mock Version: 1.2.14
Finish: chroot init
INFO: installing package(s): /home/parag/1294078-nodejs-json-diff/results/nodejs-json-diff-0.3.1-1.fc24.noarch.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 --setopt=deltarpm=false install /home/parag/1294078-nodejs-json-diff/results/nodejs-json-diff-0.3.1-1.fc24.noarch.rpm --setopt=tsflags=nocontexts


Rpmlint
-------
Checking: nodejs-json-diff-0.3.1-1.fc24.noarch.rpm
          nodejs-json-diff-0.3.1-1.fc24.src.rpm
nodejs-json-diff.noarch: W: only-non-binary-in-usr-lib
nodejs-json-diff.noarch: W: dangling-symlink /usr/lib/node_modules/json-diff/node_modules/dreamopt /usr/lib/node_modules/dreamopt
nodejs-json-diff.noarch: W: dangling-symlink /usr/lib/node_modules/json-diff/node_modules/cli-color /usr/lib/node_modules/cli-color
nodejs-json-diff.noarch: W: dangling-symlink /usr/lib/node_modules/json-diff/node_modules/difflib /usr/lib/node_modules/difflib
nodejs-json-diff.noarch: W: dangling-symlink /usr/lib/node_modules/json-diff/node_modules/should /usr/lib/node_modules/should
nodejs-json-diff.src: W: invalid-url Source2: example-0.3.1.tar.bz2
nodejs-json-diff.src: W: invalid-url Source1: tests-0.3.1.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 7 warnings.




Requires
--------
nodejs-json-diff (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(cli-color)
    npm(difflib)
    npm(dreamopt)
    npm(should)



Provides
--------
nodejs-json-diff:
    nodejs-json-diff
    npm(json-diff)



Source checksums
----------------
https://raw.githubusercontent.com/andreyvit/json-diff/master/LICENSE-MIT :
  CHECKSUM(SHA256) this package     : 34741f44ba166ae46ee3ffe7eec599a5d7fbcdf4519e28c6de6bf14342c0fb25
  CHECKSUM(SHA256) upstream package : 34741f44ba166ae46ee3ffe7eec599a5d7fbcdf4519e28c6de6bf14342c0fb25
https://registry.npmjs.org/json-diff/-/json-diff-0.3.1.tgz :
  CHECKSUM(SHA256) this package     : 172f9868100b14fba7dc1ca429a18b90f6036bac51926a04e2bb68bda3bffdc6
  CHECKSUM(SHA256) upstream package : 172f9868100b14fba7dc1ca429a18b90f6036bac51926a04e2bb68bda3bffdc6


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20

Suggestions
1) Remove the comment 
# tests disabled due to missing npm(cli-color) module, which itself has
# a metric ton of missing dependencies
as I see tests are enabled.

2)Good to have more words in summary and description like
"Structural diff for JSON files"

3) Above installation errors are due to missing dependency "npm(dreamopt) >= 0.8.0 ". Please fix this before package import. Looks like package is neither available in Fedora nor its submitted for package review but I can see its on your fedorapeople space.



APPROVED.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-json-diff

built in rawhide

When can this review be closed?