Bug 1294209

Summary:	glusterfs.spec.in: use %global per Fedora packaging guidelines
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	build	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, ndevos
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-16 13:52:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kaleb KEITHLEY 2015-12-25 12:56:40 UTC

Description of problem:

use of %global is preferred over %define

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2015-12-25 13:18:50 UTC

REVIEW: http://review.gluster.org/13079 (glusterfs.spec.in: use %global per Fedora pkg guidelines) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Vijay Bellur 2015-12-26 09:22:16 UTC

COMMIT: http://review.gluster.org/13079 committed in master by Niels de Vos (ndevos) 
------
commit 618f130ed0e653566db34878b36a2db34dcd6723
Author: Kaleb S KEITHLEY <kkeithle>
Date:   Fri Dec 25 08:11:54 2015 -0500

    glusterfs.spec.in: use %global per Fedora pkg guidelines
    
    ref. recent emails in fedora-devel ml
    
    See:
      https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define
    and the thread beginning at
      https://www.redhat.com/archives/fedora-packaging/2009-May/msg00095.html
    
    Also fix a couple instances of %if ... %else ... %endif indentation
    to be consistent with the rest of the .spec
    
    Change-Id: Iaf7332fd8601d78bc0d8249033cff12a452654bf
    BUG: 1294209
    Signed-off-by: Kaleb S KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/13079
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 13:52:16 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user