Bug 1294852 (kf5-libksane)
| Summary: | Review Request: kf5-libksane - SANE Library interface for KDE | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Pier Luigi Fiorini <pierluigi.fiorini> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mattia.verga, package-review, pierluigi.fiorini |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | pierluigi.fiorini:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-03 17:57:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1294838 | ||
|
Description
Rex Dieter
2015-12-30 17:14:00 UTC
rdieter's scratch build of kf5-libksane-15.12.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349465 ping, do you plan on continuing reviewing this package? Yes I will do it tonight. Sorry for the delay. name: ok source: ok SHA1 0c69697a66d6d0908d3822ecebedb08c2c424942 libksane-15.12.0.tar.xz license: ok post/postun ldconfig: ok filelist: ok APPROVE Pier Luigi, I don't think this way of conducting reviews are acceptable. You do them in a too simplified way. You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines or you can use fedora-review tool to automate that. For example, in this review the .src.rpm file refers to libksane-15.12.0 while the .spec file is for libksane-15.12.1 and using fedora-review the check fails. I know Rex is a "trusted" packager, but for the future please make reviews with better quality. > Pier Luigi, I don't think this way of conducting reviews are acceptable. You do > them in a too simplified way. > > You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines or you can use fedora-review tool to automate that. For simplicity I didn't put all the review check list items in the report here. Thanks for suggesting fedora-review. > For example, in this review the .src.rpm file refers to libksane-15.12.0 while > the .spec file is for libksane-15.12.1 and using fedora-review the check fails. That was changed after I picked up the review but didn't come to my mind to download the files again. Next time I'll be more accurate. Pier, you said approve in comment #4, but did not set the fedora-review flag to + , can you do so please? imported, thanks kf5-libksane-15.12.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b kf5-libksane-15.12.3-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |