Bug 1294852 (kf5-libksane) - Review Request: kf5-libksane - SANE Library interface for KDE
Summary: Review Request: kf5-libksane - SANE Library interface for KDE
Keywords:
Status: CLOSED ERRATA
Alias: kf5-libksane
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pier Luigi Fiorini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews digikam-5.0
TreeView+ depends on / blocked
 
Reported: 2015-12-30 17:14 UTC by Rex Dieter
Modified: 2016-04-07 15:52 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-03 17:57:28 UTC
Type: ---
Embargoed:
pierluigi.fiorini: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2015-12-30 17:14:00 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libksane.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libksane-15.12.0-1.fc23.src.rpm
Description: SANE Library interface for KDE
Fedora Account System Username: rdieter

Comment 1 Upstream Release Monitoring 2015-12-30 17:27:21 UTC
rdieter's scratch build of kf5-libksane-15.12.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349465

Comment 2 Rex Dieter 2016-02-07 19:57:31 UTC
ping, do you plan on continuing reviewing this package?

Comment 3 Pier Luigi Fiorini 2016-02-08 09:29:46 UTC
Yes I will do it tonight. Sorry for the delay.

Comment 4 Pier Luigi Fiorini 2016-02-08 23:45:05 UTC
name: ok

source: ok
SHA1 0c69697a66d6d0908d3822ecebedb08c2c424942 libksane-15.12.0.tar.xz

license: ok

post/postun ldconfig: ok

filelist: ok


APPROVE

Comment 5 Mattia Verga 2016-02-09 07:52:42 UTC
Pier Luigi, I don't think this way of conducting reviews are acceptable. You do them in a too simplified way.

You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines or you can use fedora-review tool to automate that.

For example, in this review the .src.rpm file refers to libksane-15.12.0 while the .spec file is for libksane-15.12.1 and using fedora-review the check fails.

I know Rex is a "trusted" packager, but for the future please make reviews with better quality.

Comment 6 Pier Luigi Fiorini 2016-02-15 23:30:04 UTC
> Pier Luigi, I don't think this way of conducting reviews are acceptable. You do > them in a too simplified way.
> 
> You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines or you can use fedora-review tool to automate that.

For simplicity I didn't put all the review check list items in the report here.
Thanks for suggesting fedora-review.

> For example, in this review the .src.rpm file refers to libksane-15.12.0 while > the .spec file is for libksane-15.12.1 and using fedora-review the check fails.

That was changed after I picked up the review but didn't come to my mind to download the files again. Next time I'll be more accurate.

Comment 7 Rex Dieter 2016-02-21 11:57:17 UTC
Pier, you said approve in comment #4, but did not set the fedora-review flag to + , can you do so please?

Comment 8 Rex Dieter 2016-03-29 14:02:52 UTC
imported, thanks

Comment 9 Fedora Update System 2016-03-29 14:26:49 UTC
kf5-libksane-15.12.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b

Comment 10 Fedora Update System 2016-03-29 14:27:37 UTC
kf5-libksane-15.12.3-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a

Comment 11 Fedora Update System 2016-03-30 22:27:08 UTC
kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b

Comment 12 Fedora Update System 2016-03-30 22:55:41 UTC
kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a

Comment 13 Fedora Update System 2016-04-03 17:57:26 UTC
kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-04-07 15:52:08 UTC
kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.