Bug 1295540

Summary: Cannot start a build referring directly to git repository
Product: [Community] Copr Reporter: Jan Pokorný [poki] <jpokorny>
Component: frontendAssignee: clime
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: clime, link, redhat-bugzilla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-04 08:58:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch that might solve denormalized/broken build links none

Description Jan Pokorný [poki] 2016-01-04 19:21:23 UTC
There seems to be an issue in the form validation step.

At http://copr.fedoraproject.org/coprs/jpokorny/booth/new_build_mock/
- SCM Type: Git
- SCM URL: https://github.com/ClusterLabs/booth.git
- Spec File: booth.spec
- Git Branch: (either empty or "master")
- various permutations of the checkboxes at the bottom

-> Build -> "This field is required." message above the form


Got the same result with "Git and Tito" way.
Tried also with jpokorny/clufter + https://pagure.io/clufter.git
+ misc/clufter.spec combo but no cigar.

Comment 1 Link Dupont 2016-01-06 05:33:19 UTC
I was getting this error yesterday as well. Today, I can submit a build using Mock SCM, but the build immediately fails with "Unknown error". SRPM Upload succeeds.

Comment 2 Jan Pokorný [poki] 2016-01-07 19:46:02 UTC
Created attachment 1112606 [details]
Patch that might solve denormalized/broken build links

re [comment 1]:

Confirming, the web form validation issue looks solved now.

The current results I can observe with booth per above setup:

Source Type: Mock build from a SCM repository 
-> Build State: failed
-> State Description: Unknown error.
(e.g., https://copr.fedoraproject.org/coprs/jpokorny/booth/build/152110/)

Source Type: Tito build from a Git repository
-> Build State: failed
-> State Description: Attempt to build SRPM have failed.
(e.g., https://copr.fedoraproject.org/coprs/jpokorny/booth/build/152111/)

Apparently, user is helpless here as no proper logs are provided.
-> sub-RFE: please provide better diagnostics for these dynamic
   types of importing a package to be built


Beside that, there is an issue with rendering
"/<username>/<coprname>/builds/" template wrt. build id links:

>       <tr class="build-row" >
>         <td data-order="152111">
>           <a href="
>   
>     /coprs/jpokorny/booth/build/152111/
>   
> ">
>             152111
>           </a>
>         </td>
>         <td>

Which might be solved with the attached patch (UNTESTED).

Comment 3 clime 2016-01-16 19:08:47 UTC
"Git & Tito" seems to work on copr-fe-dev.cloud.fedoraproject.org right now (srpms are successfully imported and builds run).

Comment 4 clime 2016-01-21 13:13:57 UTC
Currently "Git and Tito" should work on the production instance. The main problem was missing dependency.

Apart from that, I agree that better diagnostic output is needed.

Comment 5 Robert Scheck 2016-01-21 22:14:19 UTC
"Mock SCM" seems to be broken further on.

Comment 6 clime 2016-01-23 16:44:07 UTC
Should be fixed now (bad user config on the server, probly some change in .spec file will be needed, I'll look into it). Thanks for the report.

These two features are still experimental so you might expect some problems. We will improve it in very near future.

Comment 7 clime 2016-01-25 14:53:03 UTC
Better diagnostics and error handling provided by 4e2245f554

Comment 8 clime 2016-01-25 16:24:11 UTC
The problem with leading/trailing whitespaces in the generated links is now (partially) solved by 13cd5e7bc3

Comment 9 Jan Pokorný [poki] 2016-01-29 13:12:45 UTC
Note that Mock SCM builds fail in staging instance
(1.80-1.git.85.0b772db.fc23) where they work OK
in the production (1.79-1.fc23).

Comment 10 Miroslav Suchý 2016-02-03 12:28:41 UTC
Code with this fix is currently deployed on copr-fe-dev.cloud.fedoraproject.org. You can test it there before it will be deployed to production.

Comment 11 Miroslav Suchý 2016-02-04 08:58:13 UTC
This fix has been just deployed to production.