Bug 1295642

Summary: <reservesys/> is silently discarded from job XML
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: generalAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: developCC: dcallagh, dowang, mjia, rjoost
Target Milestone: 22.0Keywords: Patch, Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-01-14 05:33:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Callaghan 2016-01-05 05:29:13 UTC 
Description of problem:
<reservesys/> is silently discarded from job XML.

Version-Release number of selected component (if applicable):
22.0rc1 (does not affect any released version)

How reproducible:
easily

Steps to Reproduce:
1. Submit a job which uses <reservesys/> after the <task/> elements in the <recipe/>
(see https://beaker-project.org/docs/user-guide/system-reservation.html#using-the-reservesys-element)

Actual results:
Beaker does not reserve the system at the end of the recipe.
If you clone the job, the <reservesys/> element is missing.

Expected results:
Beaker should reserve the system at the end of the recipe.
The <reservesys/> element should be preserved when the job is cloned.

Additional info:
Regression in recipe XML parsing due to the lxml conversion. <reservesys/> is missing from complete-job.xml so parsing of <reservesys/> is not covered by any tests.
Comment 1 Dan Callaghan 2016-01-05 05:50:33 UTC 
http://gerrit.beaker-project.org/4563
Comment 5 Dan Callaghan 2016-01-14 05:33:18 UTC 
Beaker 22.0 has been released.