Bug 1296927

Summary:	[DOCS] NO_PROXY should have correct hostname
Product:	OpenShift Container Platform	Reporter:	Jaspreet Kaur <jkaur>
Component:	Documentation	Assignee:	Ashley Hardin <ahardin>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Vikram Goyal <vigoyal>
Severity:	high	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	high
Version:	3.1.0	CC:	abutcher, aos-bugs, jkaur, jliggitt, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-02 13:52:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jaspreet Kaur 2016-01-08 13:08:31 UTC

Document URL: https://access.redhat.com/documentation/en/openshift-enterprise/version-3.1/installation-and-configuration/#working-with-http-proxies

Section Number and Name: 12.2. Configuring Hosts for Proxies

Describe the issue: Since the documentation mentions the hostname of master to br added to /etc/sysconfig/atomic-openshift-master

NO_PROXY=master.hostname.example.com

It fails with below error when using "oc log" or "oc exec" since logs and exec are connections made from the client to the master
then the master connects to the kubelet running on the relevant node. 

Error from server: Get https://node.example.com:10250/containerLogs/ng-demo/aa-demo-4-dnq2r/aa-demo: Service Unavailable

Suggestions for improvement: Since the environment can have many nodes so the best way to rectify the situation is to use  wildcard, ie: NO_PROXY=*.example.com

Additional information:

Comment 1 Jaspreet Kaur 2016-01-08 13:36:33 UTC

It works with NO_PROXY=.example.com and not with *.example.com

Comment 2 Jaspreet Kaur 2016-03-31 10:41:46 UTC

There is no mention what should be added in case of HA Environment.

What is the role of adding Proxy in below files :

 /etc/sysconfig/atomic-openshift-master-api and /etc/sysconfig/atomic-openshift-master-controller file

Please be clear in the documenation as it does effect in case of importing image streams.

Regards,
Jaspreet

Comment 3 Ashley Hardin 2016-04-11 15:24:45 UTC

@Andrew @Jordan,
Most of what this BZ needs is addressed in this PR: https://github.com/openshift/openshift-docs/pull/1864. However, I'm not sure how to address Jaspreet's last comment. Can you please offer guidance, or help point me in the right direction? Thanks!

Comment 4 Andrew Butcher 2016-04-11 18:47:58 UTC

I think Jaspreet is requesting that we add the specific sysconfig files that must be updated in this section. These paths will be different on origin and enterprise so they should be conditionalized.

Origin
Single master configuration: /etc/sysconfig/origin-master
Multi-master configuration:  /etc/sysconfig/origin-master-api
                             /etc/sysconfig/origin-master-controllers
Node configuration:          /etc/sysconfig/origin-node

Enterprise
Single master configuration: /etc/sysconfig/atomic-openshift-master
Multi-master configuration:  /etc/sysconfig/atomic-openshift-master-api
                             /etc/sysconfig/atomic-openshift-master-controllers
Node configuration:          /etc/sysconfig/atomic-openshift-node

The steps for restarting masters will be different for multi-master installations as well.

Origin
systemctl restart origin-master-controllers
systemctl restart origin-master-api

Enterprise
systemctl restart atomic-openshift-master-controllers
systemctl restart atomic-openshift-master-api

Comment 5 Ashley Hardin 2016-04-12 20:12:38 UTC

Work in progress: https://github.com/openshift/openshift-docs/pull/1889

Comment 6 Ashley Hardin 2016-04-12 20:14:09 UTC

@Jaspreet Please review and let me know what you think: https://github.com/openshift/openshift-docs/pull/1889. 

Related work is here: https://github.com/openshift/openshift-docs/pull/1864

Comment 7 Ashley Hardin 2016-04-22 13:22:51 UTC

Approved by Jaspreet via e-mail.

Comment 8 openshift-github-bot 2016-04-22 13:29:57 UTC

Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/39d9ddcd1d819d7701535d2f6ef4ab2842c57090
Bug 1296927, added specific sysconfig files

https://github.com/openshift/openshift-docs/commit/48358e1daa947518f6ba84bb3bc0e86c24dab6b5
Merge pull request #1889 from ahardin-rh/sysconfig-files

Bug 1296927, added specific sysconfig files

Comment 9 Ashley Hardin 2016-05-02 13:52:33 UTC

Content is now published:
https://access.redhat.com/documentation/en/openshift-enterprise/version-3.1/installation-and-configuration/#configuring-hosts-for-proxies