| Summary: | Review Request: python-beanbag - A helper module for accessing REST APIs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stanislav Ochotnicky <sochotni> | ||||
| Component: | Package Review | Assignee: | Ralph Bean <rbean> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review, rbean | ||||
| Target Milestone: | --- | Flags: | rbean:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-02-09 20:55:04 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1297411 | ||||||
| Attachments: |
|
||||||
|
Description
Stanislav Ochotnicky
2016-01-08 15:24:56 UTC
sochotni's scratch build of python-beanbag-1.9.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12467424 Created attachment 1112947 [details]
patch to python-beanbag.spec
Patch to update the specfile.
Hi Stanislav, I attached a patch to the specfile which should update it to reflect some of the more current practices for python packaging. I'll take the review once you can have a look over that and re-post an updated version of the srpm. sochotni's scratch build of python-beanbag-1.9.2-2.fc22.src.rpm for epel7-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12494939 So... I did notice py2_build etc macros in example in the python guidelines however it's not at all mentioned otherwise and I wasn't sure what to make of it. Of course the macros are not in EL6 - but then again I guess I don't have to care about it too much (FYI build on EL6 does fail because of that though - https://kojipkgs.fedoraproject.org//work/tasks/4945/12494945/build.log) I also wasn't sure how to interpret the subpackage provides etc - but I see now that that they are supposed to really be used in python2/python3 subpackages instead of main package. That certainly makes sense, it just seemed ... weird not to have main package I guess. Thanks for the patch, it does look cleaner now. New SRPM: https://sochotni.fedorapeople.org/packages/python-beanbag-1.9.2-2.fc21.src.rpm Looks good to me now. Package Approved! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-beanbag python-beanbag-1.9.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8 python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-06e25cc466 python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8 python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |