Bug 1296974 - Review Request: python-beanbag - A helper module for accessing REST APIs
Summary: Review Request: python-beanbag - A helper module for accessing REST APIs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralph Bean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1297411
TreeView+ depends on / blocked
 
Reported: 2016-01-08 15:24 UTC by Stanislav Ochotnicky
Modified: 2016-02-10 11:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-09 20:55:04 UTC
Type: ---
rbean: fedora-review+


Attachments (Terms of Use)
patch to python-beanbag.spec (3.54 KB, patch)
2016-01-08 18:40 UTC, Ralph Bean
no flags Details | Diff

Description Stanislav Ochotnicky 2016-01-08 15:24:56 UTC
Spec URL: http://sochotni.fedorapeople.org//python-beanbag.spec
SRPM URL: http://sochotni.fedorapeople.org//python-beanbag-1.9.2-1.fc22.src.rpm

Description:
BeanBag is a simple module that lets you access REST APIs in an easy way. For
example:

>>> import beanbag
>>> github = beanbag.BeanBag("https://api.github.com")
>>> watchers = github.repos.ajtowns.beanbag.watchers()
>>> for w in watchers:
...     print(w["login"])

See http://beanbag.readthedocs.org/ for more information.

Comment 1 Upstream Release Monitoring 2016-01-08 15:30:58 UTC
sochotni's scratch build of python-beanbag-1.9.2-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12467424

Comment 2 Ralph Bean 2016-01-08 18:40:55 UTC
Created attachment 1112947 [details]
patch to python-beanbag.spec

Patch to update the specfile.

Comment 3 Ralph Bean 2016-01-08 18:42:24 UTC
Hi Stanislav, I attached a patch to the specfile which should update it to reflect some of the more current practices for python packaging.  I'll take the review once you can have a look over that and re-post an updated version of the srpm.

Comment 4 Upstream Release Monitoring 2016-01-11 07:27:35 UTC
sochotni's scratch build of python-beanbag-1.9.2-2.fc22.src.rpm for epel7-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12494939

Comment 5 Stanislav Ochotnicky 2016-01-11 07:54:11 UTC
So... I did notice py2_build etc macros in example in the python guidelines however it's not at all mentioned otherwise and I wasn't sure what to make of it. Of course the macros are not in EL6 - but then again I guess I don't have to care about it too much (FYI build on EL6 does fail because of that though - https://kojipkgs.fedoraproject.org//work/tasks/4945/12494945/build.log)

I also wasn't sure how to interpret the subpackage provides etc - but I see now that that they are supposed to really be used in python2/python3 subpackages instead of main package. That certainly makes sense, it just seemed ... weird not to have main package I guess.

Thanks for the patch, it does look cleaner now.

New SRPM: https://sochotni.fedorapeople.org/packages/python-beanbag-1.9.2-2.fc21.src.rpm

Comment 6 Ralph Bean 2016-01-11 16:20:02 UTC
Looks good to me now.  Package Approved!

Comment 7 Gwyn Ciesla 2016-01-11 19:56:17 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-beanbag

Comment 8 Fedora Update System 2016-01-15 18:44:40 UTC
python-beanbag-1.9.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8

Comment 9 Fedora Update System 2016-01-16 19:21:45 UTC
python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-06e25cc466

Comment 10 Fedora Update System 2016-01-17 14:23:47 UTC
python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4862ff15f8

Comment 11 Fedora Update System 2016-02-09 20:55:03 UTC
python-beanbag-1.9.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-02-10 11:14:07 UTC
python-beanbag-1.9.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.