Bug 1298748
| Summary: | ISO provisioning always fails because it can't start the VM while the disk is locked | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Josh Carter <jocarter> | |
| Component: | Automate | Assignee: | Drew Bomhof <dbomhof> | |
| Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.5.0 | CC: | cpelland, dbomhof, jhardy, jprause, mfeifer, mkanoor, obarenbo, tfitzger | |
| Target Milestone: | GA | Keywords: | ZStream | |
| Target Release: | 5.6.0 | |||
| Hardware: | All | |||
| OS: | All | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.6.0.0 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1301660 1301662 (view as bug list) | Environment: | ||
| Last Closed: | 2016-06-29 15:30:27 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1301660, 1301662 | |||
|
Description
Josh Carter
2016-01-14 22:25:02 UTC
Drew - The customize_destination state in rhev native provisioning calls destination_image_locked? and re-queues the state if the provider returns that the image is locked. Both ISO and PXE provisioning override this method and do not have the destination_image_locked? check. Might be worth investigating if there is a way to make the first part of customize_destination common that could handle the image locked check and then transition to a state that can be overridden for the different provisioning types (native, iso, pxe) which all do different actions in the customize_destination method today. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/ccee4be4278e46999e7498bbff10929d1a602f95 commit ccee4be4278e46999e7498bbff10929d1a602f95 Author: Drew Bomhof <dbomhof> AuthorDate: Tue Jan 19 15:35:12 2016 -0500 Commit: Drew Bomhof <dbomhof> CommitDate: Tue Jan 19 15:54:35 2016 -0500 Added destination_image_locked? check to RHEV iso/pxe provisioning https://bugzilla.redhat.com/show_bug.cgi?id=1298748 The destination_image_locked? method was only being called on native RHEV provisioning. This change slightly refactors the customize_destination method to enable the destination_image_locked? check for all RHEV provisioning types .../infra_manager/provision/state_machine.rb | 9 ++++--- .../provision_via_iso/state_machine.rb | 8 +----- .../provision_via_pxe/state_machine.rb | 7 +----- .../infra_manager/provision/state_machine_spec.rb | 9 +++++-- .../provision_via_iso/state_machine_spec.rb | 9 +++++-- .../provision_via_pxe/state_machine_spec.rb | 29 ++++++++++++++++++++++ 6 files changed, 51 insertions(+), 20 deletions(-) create mode 100644 spec/models/manageiq/providers/redhat/infra_manager/provision_via_pxe/state_machine_spec.rb *** Bug 1301662 has been marked as a duplicate of this bug. *** New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d547fbc7ccb8202f1f6fcaf798d3ead9615c0bb2 commit d547fbc7ccb8202f1f6fcaf798d3ead9615c0bb2 Author: Drew Bomhof <dbomhof> AuthorDate: Tue Jan 19 15:35:12 2016 -0500 Commit: Drew Bomhof <dbomhof> CommitDate: Mon Jan 25 15:05:16 2016 -0500 Added destination_image_locked? check to RHEV iso/pxe provisioning https://bugzilla.redhat.com/show_bug.cgi?id=1298748 The destination_image_locked? method was only being called on native RHEV provisioning. This change slightly refactors the customize_destination method to enable the destination_image_locked? check for all RHEV provisioning types .../infra_manager/provision/state_machine.rb | 9 +++-- .../provision_via_iso/state_machine.rb | 8 +--- .../provision_via_pxe/state_machine.rb | 7 +--- .../infra_manager/provision/state_machine_spec.rb | 44 ++++++++++++---------- .../provision_via_iso/state_machine_spec.rb | 15 +++++--- .../provision_via_pxe/state_machine_spec.rb | 29 ++++++++++++++ 6 files changed, 72 insertions(+), 40 deletions(-) create mode 100644 spec/models/manageiq/providers/redhat/infra_manager/provision_via_pxe/state_machine_spec.rb Fixed. Verified in 5.6.0.1-beta2.20160413141124_e25ac0e Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |