Bug 1298772
| Summary: | Improve "there are no free USB channels" string as it can be read as an error message | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Yanan Fu <yfu> | |
| Component: | spice-gtk | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> | |
| Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 6.8 | CC: | astepano, cfergeau, chayang, dblechte, fidencio, jinzhao, jjongsma, juzhang, kraxel, mxie, pgrunt, rbalakri, rduda, tzheng, xiaodwan, yfu | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Windows | |||
| Whiteboard: | ||||
| Fixed In Version: | spice-gtk-0.26-8.el6 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1299931 1299932 (view as bug list) | Environment: | ||
| Last Closed: | 2017-03-21 09:16:21 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1299931, 1299932 | |||
|
Description
Yanan Fu
2016-01-15 02:02:00 UTC
I have confirmed with Gerd (kraxel) about this issue before.
And he kindly answer my question, this is the mail he replied to me:
================================================================================
Hi,
> 2.plug one usb in the host.
> 3.in the host, connect to the guest with "remoter-viewer spice://..."
> 4.in remoter viewer, click "File"--->"USB device selection", choose the given usb device,
> it will show "there are no free USB channels"
> but in boot menu, "usb device" can be list after this operation.
> "info spice" can see one channel name "usbredir":
remote-viewer *successfully* redirected the usb device. The device got
the one available slot.
Now you can't redirect *more* usb devices because there isn't a free
slot any more. This is what the message tries to say. It's confusing
indeed, because the message can easily be interpreted as some kind of
error even though it isn't.
It would probably be better to have a message saying how much free slots
are there, and have it displayed all the time. So you tick one usb
device, and see the count go down from one to zero. Untick the device,
and see the count go up to one again. It's much more transparent what
is happening on then.
I'd suggest to open a bug for remote-viewer. Feel free to cut&paste the
paragraphs above into bugzilla.
HTH,
Gerd
================================================================================
(In reply to Yanan Fu from comment #1) > I have confirmed with Gerd (kraxel) about this issue before. > And he kindly answer my question, this is the mail he replied to me: > > ============================================================================= > === > Hi, > > > 2.plug one usb in the host. > > 3.in the host, connect to the guest with "remoter-viewer spice://..." > > 4.in remoter viewer, click "File"--->"USB device selection", choose the given usb device, > > it will show "there are no free USB channels" > > but in boot menu, "usb device" can be list after this operation. > > "info spice" can see one channel name "usbredir": > > remote-viewer *successfully* redirected the usb device. The device got > the one available slot. > > Now you can't redirect *more* usb devices because there isn't a free > slot any more. This is what the message tries to say. It's confusing > indeed, because the message can easily be interpreted as some kind of > error even though it isn't. > > It would probably be better to have a message saying how much free slots > are there, and have it displayed all the time. So you tick one usb > device, and see the count go down from one to zero. Untick the device, > and see the count go up to one again. It's much more transparent what > is happening on then. > > I'd suggest to open a bug for remote-viewer. Feel free to cut&paste the > paragraphs above into bugzilla. > > HTH, > Gerd > > ============================================================================= > === Personally, I don't like the idea of adding a message everytime a USB gets connected/disconnected. It seems a bit annoying, to be honest. Another option could have this info exposed by spice-gtk and then we can have, in the 'Select USB devices for redirection" modal dialog something like: ΅Select USB devices to redirect (%d free slots):" Hi,
> Personally, I don't like the idea of adding a message everytime a USB gets
> connected/disconnected. It seems a bit annoying, to be honest.
> Another option could have this info exposed by spice-gtk and then we can
> have, in the 'Select USB devices for redirection" modal dialog something
> like:
> ΅Select USB devices to redirect (%d free slots):"
The "there are no free USB channels" message actually appears inside the modal device selection dialog, right above the checkboxes. It's not a separate message box.
It appears the moment you tick a usb device checkbox, so it is very easily misinterpreted as error message. Which should be fixed, and I think the best
is to remove that message and instead display the number of available slots (permanently) and of course update it as devices are ticked/unticked.
How exactly the number of slots is displayed doesn't matter that much. Could be done at the place where the "no free channels" message used to show up (my suggestion), but changing the text above the checkboxes as you've suggested is fine with me too.
I've been talking a bit with the team and a few suggestions came up. Jonathon suggested changing the current message to "All available USB channels are in use. No additional devices can be redirected". Would it be clear enough? What about having this new message + the INFO icon in the GtkInfoBar (nowadays we use the the WARNING icon)? (In reply to Fabiano Fidêncio from comment #6) > I've been talking a bit with the team and a few suggestions came up. > Jonathon suggested changing the current message to "All available USB > channels are in use. No additional devices can be redirected". Would it be > clear enough? > What about having this new message + the INFO icon in the GtkInfoBar > (nowadays we use the the WARNING icon)? I think it is still not very clear with the new message. when tick a usb device checkbox, it show the messgae: "All available USB channels are in use. No additional devices can be redirected" it still can be misinterpreted that i can not choose this device. can there be no any message when choose the last one? In case: there are no device can be redirect and we choose one device, it show show the message? or the current message can be changed more clearly, such as "This is the last device can be redirected" ? (In reply to Yanan Fu from comment #7) > or the current message can be changed more clearly, such as "This is the > last device can be redirected" ? No, that message doesn't really work well. Try closing that dialog after redirecting the last device. Now imagine that you've been using the guest for a while and you open the usb redirection dialog again to try to redirect another USB device. The same message will be displayed (for example, "This is the last device..."). This message doesn't really make sense in this situation becuase it's not clear what "this" is referring to. You haven't just finished redirecting a device, you've only opened the dialog. And in fact, that message might even make the user think that they can still redirect one more device (which is not true). (In reply to Jonathon Jongsma from comment #8) > No, that message doesn't really work well. Try closing that dialog after > redirecting the last device. Now imagine that you've been using the guest > for a while and you open the usb redirection dialog again to try to redirect > another USB device. The same message will be displayed (for example, "This > is the last device..."). This message doesn't really make sense in this > situation becuase it's not clear what "this" is referring to. You haven't > just finished redirecting a device, you've only opened the dialog. And in > fact, that message might even make the user think that they can still > redirect one more device (which is not true). yes,you are right, i miss consider this situation. does the following method feasible? or you have better solution. " can there be no any message when choose the last one? In case: there are no device can be redirect and we choose one device, it show show the message? " We can solve this issue with these 2 patches (one already pushed upstream and the other one must be downstream only): 5166f891e566586bffcdc21b4b7386bf260bedc9 (spice-gtk) http://lists.freedesktop.org/archives/spice-devel/2016-January/025950.html This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions moving to verified: tested on rhel 6.9 with config spice-gtk-0.26.8.el6.x86_64 virt-viewer-2.0-17.el6.x86_64 Proper number of free USB channels was displayed. When there was no free channel, another checkboxes of USB devices were disabled. Downgraded to spice-gtk-0.26-7.el6.x86_64 -> old behaviour reproduced (e.g. no number of free USB channels and warning message) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2017-0587.html |