Bug 1299142
Summary: | python-pyspf: Provide a Python 3 subpackage | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> | ||||||||||||||
Component: | python-pyspf | Assignee: | Paul Wouters <pwouters> | ||||||||||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||
Severity: | unspecified | Docs Contact: | |||||||||||||||
Priority: | unspecified | ||||||||||||||||
Version: | 24 | CC: | cstratak, dkrejci, jberan, pwouters | ||||||||||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||||||||||
Target Release: | --- | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Whiteboard: | |||||||||||||||||
Fixed In Version: | python-pyspf-2.0.12-1.fc26 python-pyspf-2.0.12-1.fc25 python-pyspf-2.0.12-1.fc24 | Doc Type: | Bug Fix | ||||||||||||||
Doc Text: | Story Points: | --- | |||||||||||||||
Clone Of: | Environment: | ||||||||||||||||
Last Closed: | 2016-12-04 02:26:28 UTC | Type: | Bug | ||||||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||||||
Documentation: | --- | CRM: | |||||||||||||||
Verified Versions: | Category: | --- | |||||||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
Embargoed: | |||||||||||||||||
Bug Depends On: | |||||||||||||||||
Bug Blocks: | 1285816, 1333770 | ||||||||||||||||
Attachments: |
|
Description
Petr Viktorin (pviktori)
2016-01-16 15:13:14 UTC
Ping? No response as of yet from maintainer. Also latest upstream version: 2.0.12 This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase Hello Paul, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html Created attachment 1198762 [details]
New version including Python 3 subpackage
(In reply to Jan Beran from comment #4) > Created attachment 1198762 [details] > New version including Python 3 subpackage Hi Jan, please, do not define `%global summary` macro on the second line, it is redundant, because there is already `Summary:` tag. ;) Koji scratch buid: http://koji.fedoraproject.org/koji/taskinfo?taskID=15539340 Created attachment 1199059 [details]
Adjusted spec file
Hi Dominika,
thank you for the review. I attach the spec file where the inappropriate name is fixed.
Delete second line in the specfile. Do not specify the macro at all (no %global sum/summary). It will be automatically defined by the `Summary: Python module...` tag. Than you can use %{summary} in the rest of the spec, as you did in the first case. Take a look at the example spefile there: http://python-rpm-porting.readthedocs.io/en/latest/application-modules.html#ported-rpm-spec-file Created attachment 1199100 [details]
Updated spec file
Hi Dominika, thank you for the hint, I have fixed the spec file. (I am really stupid, it is logical).
Hi Jan, same issue with summary there. Definition of %{sum} macro is redundant. Hi Dominika, you probably refer to another bugzillas (I am going to fix it there), not this one. (In reply to Jan Beran from comment #10) > Hi Dominika, you probably refer to another bugzillas (I am going to fix it > there), not this one. Of course, I had more bugs opened, sorry. It supposed to be #1333816. Hi Jan, there are two more comments: * Please, do not add "- Python X version" to %{summary} in subpackages, it is too long. Keep it just in the description is fine. * Scripts type99 and spfquery probably should have executable rights. Created attachment 1207833 [details]
Updated spec file
Hi Dominika,
thanks for your review. I include the updated spec file that fixes your findings.
My mistake. The problem was not with type99 and spfquery (it was ok in the previous version of the spec), but with spf.py: `E: non-executable-script /usr/lib/python3.5/site-packages/spf.py 644 /usr/bin/python` I can be solved by removing the shebang in this file. Created attachment 1208332 [details]
Updated spec file
Hi Dominika,
thank you for the feedback. I have prepared fixes in the attachment. May I ask you to review again?
Hallo Jan, I hope, this will be the last thing: Please, keep the License as it was in the original specfile (just Python). Python Software Foundation License is not recognized by rpmlint and `Python` is acceptable shortcut for it. :) `python-pyspf.src: W: invalid-license Python Software Foundation License` Created attachment 1209198 [details]
Updated spec file
Hi Dominika,
my rpmlint did not report any error. However, I have updated the spec file by the short name license.
Thanks for your reviews and support.
Hi Jan, the spec looks good to me. If maintainer has nothing against, we can push this change after a week. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16060652 Modified a bit the SPEC file to fix some issues related to the ipaddress module requirement and the patch that was included in the package sources. Commit is pushed and the package has been built for rawhide. If it is required to build it as well for F25 please reopen the bug. python-pyspf-2.0.12-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae93fe8b26 python-pyspf-2.0.12-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-11e8f660a4 python-pyspf-2.0.12-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae93fe8b26 python-pyspf-2.0.12-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-11e8f660a4 python-pyspf-2.0.12-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-pyspf-2.0.12-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |