Bug 1299513
| Summary: | Add warning when creating a snapshot on a VM with no guest tools installed | |||
|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Tal Nisan <tnisan> | |
| Component: | BLL.Storage | Assignee: | Tal Nisan <tnisan> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Natalie Gavrielov <ngavrilo> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 3.6.2 | CC: | acanan, amureini, bugs, derez, eblake, gklein, michal.skrivanek, ngavrilo, ogofen, sbonazzo, tnisan, vfeenstr, ylavi | |
| Target Milestone: | ovirt-3.6.3 | Flags: | rule-engine:
ovirt-3.6.z+
rule-engine: exception+ rule-engine: planning_ack+ tnisan: devel_ack+ acanan: testing_ack+ |
|
| Target Release: | 3.6.3.2 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1297919 | |||
| : | 1300566 (view as bug list) | Environment: | ||
| Last Closed: | 2016-02-23 13:31:35 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1297919 | |||
| Bug Blocks: | 1135132 | |||
|
Description
Tal Nisan
2016-01-18 14:44:53 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone. I think it sufficient (and makes better sense) to add a warning when creating a live snapshot as the root cause is a failure in freeze/thaw process. Note that determining whether the agents (qemu-guest-agent and ovirt-guest-agent/rhevm-guest-agent) are installed is not adequate. We should probably also verify that both guests are running (not sure if the information is already available in vdsm). @Vinzenz - does vdsm exposes information regarding the guest agents statuses? I.e. can we determine whether qemu-guest-agent and ovirt-guest-agent are running? No, not that I know of - There's an unofficial way to deduce that information for our guest agent, however that's relying on something that wasn't made for it. So in short I simply say no it's not exposed. The qemu-guest-agent can't even be checked right now at all from within VDSM - We'd have to probably ask libvirt for it, and I am not sure if there's such a thing in it. I've tested the following: 1. When ovirt-guest-agent and qemu-guest-agent are NOT installed - passed, there is a warning. 2. With both installed - passed (no warning). 3. Only qemu-guest-agent installed - No warning, AFAIU there should be a warning, "guest tools" include both ovirt-guest-agent and qemu-guest-agent? 4. Is there RFE or a bug about checking if these agents are running or not? Not sure actually, we basically check vm.getHasAgent() and trust this logic, I'm not sure which one he checks. Michal, can you help here? (In reply to Natalie Gavrielov from comment #4) > I've tested the following: > > 1. When ovirt-guest-agent and qemu-guest-agent are NOT installed - passed, > there is a warning. > 2. With both installed - passed (no warning). > 3. Only qemu-guest-agent installed - No warning, AFAIU there should be a > warning, "guest tools" include both ovirt-guest-agent and qemu-guest-agent? > 4. Is there RFE or a bug about checking if these agents are running or not? Yes, I opened RFE 1300566 to cover that ([RFE] expose the status of qemu-guest-agent and ovirt-guest-agent). regardless that RFE, you should be checking whether it's running, not just installed. Don't we have another (albeit ugly) function for that? (In reply to Michal Skrivanek from comment #7) > regardless that RFE, you should be checking whether it's running, not just > installed. Don't we have another (albeit ugly) function for that? Well I could make it a dependency of the ovirt-guest-agent service when the ovirt-guest-agent is running, that one should also be running then. Tal, I haven't received a clear answer for this question.. (In reply to Natalie Gavrielov from comment #4) > 3. Only qemu-guest-agent installed - No warning, AFAIU there should be a > warning, "guest tools" include both ovirt-guest-agent and qemu-guest-agent? So I'm reopening this.. I totally agree with what Michal wrote: (In reply to Michal Skrivanek from comment #7) > regardless that RFE, you should be checking whether it's running, not just > installed. IMO, the ultimate solution is to check whether these components are installed and running (this issue together with RFE 1300566). But to check that they're running will be sufficient ('cose then, you can just warn the user that you can't find these processes, suggest that they're not running/installed..) Checking that qemu-guest-agent installed doesn't really solve the problem. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. We've given here the best solution we could to 3.6.3 given the information we have from the guest, it's hacky by nature but there's no better indication currently thus the limitations. When we have more info as requested in bug 1300566 we can give a better solution, for now this bug is meant to cover what we can currently. |