Bug 1299558
| Summary: | Review Request: python-inifile - A small INI library for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Charalampos Stratakis <cstratak> |
| Component: | Package Review | Assignee: | Robert Kuska <rkuska> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jberan, msuchy, package-review, rkuska |
| Target Milestone: | --- | Flags: | rkuska:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-30 18:22:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Charalampos Stratakis
2016-01-18 15:50:13 UTC
The check phase in specfile is redudant, no tests are run nor present in package.
"Ran 0 tests in 0.000s"
It's probably better to use %{version} macro in Source0 so you don't have to edit the link everytime you update the package.
Also you've defined %{sum} macro and used it only in main package description even though both subpackages could use it as well in their description.
These are just minor issues and otherwise it looks nice! :)
Update: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/cstratak/python-inifile/python-inifile.git/plain/python-inifile.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/cstratak/python-inifile/fedora-rawhide-x86_64/00154641-python-inifile/python-inifile-0.3-2.fc24.src.rpm Looks good, approved. Looks good to me as well. APPROVED Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-inifile python-inifile-0.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e python-inifile-0.3-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778 python-inifile-0.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18 python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18 python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778 python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |